HDDS-8120. [Snapshot] Close rocksDB connection after SstFilteringTask finishes #4366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswinshakil
changed the title
smengcl
approved these changes
Mar 9, 2023
prashantpogde
approved these changes
Mar 9, 2023
sadanand48
approved these changes
Mar 9, 2023
Contributor
|
Since we are opening snapshot rocksDB instance in RW mode, we need to make sure that auto-compaction is turned off. I have filed https://issues.apache.org/jira/browse/HDDS-8122 to track this. |
Contributor
|
thank you @DaveTeng0 for thsi patch. |
Contributor
|
Please pay attention when merging PRs. If it has a single commit, GitHub uses the commit's message by default, not the PR title. |
adoroszlai
reviewed
Mar 9, 2023
| dbName, true); | ||
| RocksDatabase db = rdbStore.getDb(); | ||
| db.deleteFilesNotMatchingPrefix(prefixPairs, filterFunction); | ||
| rdbStore.close(); |
Contributor
There was a problem hiding this comment.
Use try-with-resources to ensure close happens even in face of exceptions.
try (RDBStore rdbStore = (RDBStore) OmMetadataManagerImpl
.loadDB(ozoneManager.getConfiguration(), new File(snapshotDir),
dbName, true)) {
RocksDatabase db = rdbStore.getDb();
db.deleteFilesNotMatchingPrefix(prefixPairs, filterFunction);
}
Contributor
There was a problem hiding this comment.
Good catch. @DaveTeng0 Would you post another PR to address this?
Contributor
Author
There was a problem hiding this comment.
good catch! yeah i'll do that!
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Mar 16, 2023
* master: (262 commits) HDDS-8153. Integrate ContainerBalancer with MoveManager (apache#4391) HDDS-8090. When getBlock from a datanode fails, retry other datanodes. (apache#4357) HDDS-8163 Use try-with-resources to ensure close rockdb connection in SstFilteringService (apache#4402) HDDS-8065. Provide GNU long options (apache#4394) HDDS-7930. [addendum] input stream does not refresh expired block token. HDDS-7930. input stream does not refresh expired block token. (apache#4378) HDDS-7740. [Snapshot] Implement SnapshotDeletingService (apache#4244) HDDS-8076. Use container cache in Key listing API. (apache#4346) HDDS-8091. [addendum] Generate list of config tags from ConfigTag enum - Hadoop 3.1 compatibility fix (apache#4374) HDDS-8144. TestDefaultCertificateClient#testTimeBeforeExpiryGracePeriod fails as we approach DST. (apache#4382) HDDS-8151. Support fine grained lifetime for root CA certificate (apache#4386) HDDS-8150. RpcClientTest and ConfigurationSourceTest not run due to naming convention (apache#4388) HDDS-8131. Add Configuration for OM Ratis Log Purge Tuning Parameters. (apache#4371) HDDS-8133. Create ozone sh key checksum command (apache#4375) HDDS-8142. Check if no entries in Block DB for a container on container delete (apache#4379) HDDS-8118. Fail container delete on non empty chunks dir (apache#4367) HDDS-8028. JNI for RocksDB SST Dump tool (apache#4315) HDDS-8129. ContainerStateMachine allows two different tasks with the same container id running in parallel. (apache#4370) HDDS-8119. Remove loosely related AutoCloseable from SendContainerOutputStream (apache#4368) close db connection (apache#4366) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Close rocksDB connection after SstFilteringTask finishes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8120
How was this patch tested?
Tested in dev cluster.