Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Make the implementation of HDDS-8091 (#4359) compatible with Hadoop 3.1. Both addTags(Properties) and HADOOP_TAGS_CUSTOM were only introduced in Hadoop 3.2.

https://issues.apache.org/jira/browse/HDDS-8091

How was this patch tested?

Verified SCM web UI still can be used to browse Ozone config by tags.

@adoroszlai adoroszlai self-assigned this Mar 10, 2023
@adoroszlai adoroszlai requested a review from jojochuang March 10, 2023 13:48
@kerneltime
Copy link
Contributor

@GeorgeJahad can you take a look as well?

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you also update the title like "HDDS-8091. [addendum] ..." ? Just want to make it clear there are two commits associated with HDDS-8091.

@adoroszlai adoroszlai changed the title HDDS-8091. Generate list of config tags from ConfigTag enum - Hadoop 3.1 compatibility fix HDDS-8091. [addendum] Generate list of config tags from ConfigTag enum - Hadoop 3.1 compatibility fix Mar 14, 2023
@adoroszlai adoroszlai merged commit 62692bc into apache:master Mar 14, 2023
@adoroszlai adoroszlai deleted the HDDS-8091-followup branch March 14, 2023 18:18
@adoroszlai
Copy link
Contributor Author

Thanks @jojochuang for reporting the issue and for the review.

errose28 added a commit to errose28/ozone that referenced this pull request Mar 16, 2023
* master: (262 commits)
  HDDS-8153. Integrate ContainerBalancer with MoveManager (apache#4391)
  HDDS-8090. When getBlock from a datanode fails, retry other datanodes. (apache#4357)
  HDDS-8163 Use try-with-resources to ensure close rockdb connection in SstFilteringService (apache#4402)
  HDDS-8065. Provide GNU long options (apache#4394)
  HDDS-7930. [addendum] input stream does not refresh expired block token.
  HDDS-7930. input stream does not refresh expired block token. (apache#4378)
  HDDS-7740. [Snapshot] Implement SnapshotDeletingService (apache#4244)
  HDDS-8076. Use container cache in Key listing API. (apache#4346)
  HDDS-8091. [addendum] Generate list of config tags from ConfigTag enum - Hadoop 3.1 compatibility fix (apache#4374)
  HDDS-8144. TestDefaultCertificateClient#testTimeBeforeExpiryGracePeriod fails as we approach DST. (apache#4382)
  HDDS-8151. Support fine grained lifetime for root CA certificate (apache#4386)
  HDDS-8150. RpcClientTest and ConfigurationSourceTest not run due to naming convention (apache#4388)
  HDDS-8131. Add Configuration for OM Ratis Log Purge Tuning Parameters. (apache#4371)
  HDDS-8133. Create ozone sh key checksum command (apache#4375)
  HDDS-8142. Check if no entries in Block DB for a container on container delete (apache#4379)
  HDDS-8118. Fail container delete on non empty chunks dir (apache#4367)
  HDDS-8028. JNI for RocksDB SST Dump tool (apache#4315)
  HDDS-8129. ContainerStateMachine allows two different tasks with the same container id running in parallel. (apache#4370)
  HDDS-8119. Remove loosely related AutoCloseable from SendContainerOutputStream (apache#4368)
  close db connection (apache#4366)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants