Skip to content

HDDS-8120. [Snapshot] Close rocksDB connection after SstFilteringTask finishes #4366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashantpogde merged 1 commit into from
Mar 9, 2023
Merged

HDDS-8120. [Snapshot] Close rocksDB connection after SstFilteringTask finishes #4366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/SstFilteringService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ public BackgroundTaskResult call() throws Exception {
dbName, true);
RocksDatabase db = rdbStore.getDb();
db.deleteFilesNotMatchingPrefix(prefixPairs, filterFunction);
rdbStore.close();
Copy link
Contributor

@adoroszlai adoroszlai Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use try-with-resources to ensure close happens even in face of exceptions.

          try (RDBStore rdbStore = (RDBStore) OmMetadataManagerImpl
              .loadDB(ozoneManager.getConfiguration(), new File(snapshotDir),
                  dbName, true)) {
            RocksDatabase db = rdbStore.getDb();
            db.deleteFilesNotMatchingPrefix(prefixPairs, filterFunction);
          }

Copy link
Contributor

@smengcl smengcl Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. @DaveTeng0 Would you post another PR to address this?

Copy link
Contributor Author

@DaveTeng0 DaveTeng0 Mar 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! yeah i'll do that!


// mark the snapshot as filtered by writing to the file
String content = snapshotInfo.getSnapshotID() + "\n";
Expand Down