HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys #3987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
adoroszlai
changed the title
jojochuang
reviewed
Nov 23, 2022
Contributor
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Looks good if we follow the existing code style and have one parameter per line. +1 after the code style change.
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java
Outdated
Show resolved
Hide resolved
aswinshakil
reviewed
Nov 23, 2022
...zone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 29, 2022 18:11
aswinshakil
reviewed
Dec 3, 2022
...zone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java
Show resolved
Hide resolved
...zone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java
Outdated
Show resolved
Hide resolved
...e/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java
Outdated
Show resolved
Hide resolved
aswinshakil
reviewed
Dec 3, 2022
Member
aswinshakil
left a comment
aswinshakil
left a comment
There was a problem hiding this comment.
LGTM+1. Thanks for the patch @DaveTeng0. Just some minor comment inline.
Member
|
FYI, You can mark the conversation as resolved if the comments have been addressed. Thanks! |
aswinshakil
approved these changes
Dec 5, 2022
jojochuang
approved these changes
Dec 5, 2022
Contributor
|
Merged Thanks @DaveTeng0 @aswinshakil |
Galsza
pushed a commit
to Galsza/ozone
that referenced
this pull request
Dec 7, 2022
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Dec 12, 2022
* master: (110 commits) HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys (apache#3987) HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id (apache#3862) HDDS-7555. Upgrade Ratis to 2.4.2-8b8bdda-SNAPSHOT. (apache#4028) HDDS-7541. FSO recursive delete directory with hierarchy takes much time for cleanup (apache#4008) HDDS-7581. Fix update-jar-report for snapshot (apache#4034) HDDS-7253. Fix exception when '/' in key name (apache#4038) HDDS-7579. Use Netty 4.1.77 for consistency (apache#4031) HDDS-7562. Suppress warning about long filenames in tar (apache#4017) HDDS-7563. Add a handler for under replicated Ratis containers in RM (apache#4025) HDDS-7497. Fix mkdir does not update bucket's usedNamespace (apache#3969) HDDS-7567. Invalid entries in LICENSE (apache#4020) HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI (apache#4026) HDDS-7540. Let reusable workflow inherit secrets (apache#4012) HDDS-7568. Bump copyright year in NOTICE (apache#4018) HDDS-7394. OM RPC FairCallQueue decay decision metrics list caller username in the metric (apache#3878) HDDS-7510. Recon: Return number of open containers in `/clusterState` endpoint (apache#3989) HDDS-7561. Improve setquota, clrquota CLI usage (apache#4016) HDDS-6615. EC: Improve write performance by pipelining encode and flush (apache#3994) HDDS-7554. Recon UI should show DORMANT in pipeline status filter (apache#4010) HDDS-7540. Separate scheduled CI from push/PR workflows (apache#4004) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
EC: Fix the NSSummaryEndpoint#getDiskUsage should be fixed for EC keys
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7472
How was this patch tested?
CI's unit tests.