Skip to content

HDDS-7562. Suppress warning about long filenames in tar #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adoroszlai merged 3 commits into from
Dec 2, 2022
Merged

HDDS-7562. Suppress warning about long filenames in tar #4017

adoroszlai merged 3 commits into from
Dec 2, 2022

Conversation

@adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Nov 30, 2022

What changes were proposed in this pull request?

Suppress warning about long filenames output by maven-assembly-plugin when creating source tarball:

[INFO] --- maven-assembly-plugin:2.4:single (src-dist) @ ozone-dist ---
[INFO] Reading assembly descriptor: /home/adoroszlai/src/apache/ozone/hadoop-ozone/dist/src/main/assemblies/ozone-src.xml
[INFO] Building tar: /home/adoroszlai/src/apache/ozone/hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT-src.tar.gz
[WARNING] Entry: ozone-1.3.0-SNAPSHOT-src/dev-support/annotations/target/maven-status/maven-compiler-plugin/compile/default-compile/ longer than 100 characters.
[WARNING] Resulting tar file can only be processed successfully by GNU compatible tar commands
[WARNING] Entry: ozone-1.3.0-SNAPSHOT-src/dev-support/annotations/target/classes/META-INF/services/javax.annotation.processing.Processor longer than 100 characters.
[WARNING] Entry: ozone-1.3.0-SNAPSHOT-src/dev-support/annotations/target/classes/org/apache/ozone/annotations/RequestFeatureValidatorProcessor$ProcessingPhaseVisitor.class longer than 100 characters.
[WARNING] Entry: ozone-1.3.0-SNAPSHOT-src/dev-support/annotations/target/classes/org/apache/ozone/annotations/ReplicateAnnotationProcessor.class longer than 100 characters.
[WARNING] Entry: ozone-1.3.0-SNAPSHOT-src/dev-support/annotations/target/classes/org/apache/ozone/annotations/RequestFeatureValidatorProcessor$ConditionValidator.class longer than 100 characters.
...

https://issues.apache.org/jira/browse/HDDS-7562

How was this patch tested?

Verified that warnings are gone, tarball is unchanged.

$ git checkout master
$ mvn -B -Psrc -DskipTests clean verify > tee master.log
$ mv hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT-src.tar.gz master.tar.gz

$ git checkout HDDS-7562
$ mvn -B -Psrc -DskipTests clean verify > tee patch.log
$ mv hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT-src.tar.gz patch.tar.gz

$ wc -l master.log patch.log 
   6625 master.log
   2880 patch.log
   9505 total

$ diff -uw \
    <(tar tzvf master.tar.gz | awk '{ print $NF }' | sort) \
    <(tar tzvf patch.tar.gz | awk '{ print $NF }' | sort) \
    | wc -l
0

Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/3582866264

@adoroszlai adoroszlai self-assigned this Nov 30, 2022
@adoroszlai adoroszlai added the build Pull request that modifies the build process label Nov 30, 2022
kerneltime
kerneltime reviewed Dec 1, 2022
View reviewed changes
hadoop-ozone/dist/pom.xml Outdated
<appendAssemblyId>false</appendAssemblyId>
<attach>false</attach>
<finalName>ozone-${project.version}-src</finalName>
<tarLongFileMode>gnu</tarLongFileMode>
Copy link
Contributor

@kerneltime kerneltime Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look, perhaps this should be posix? Ref: assembly plugin should use posix, not gnu for tarLongFileMode

Copy link
Contributor Author

@adoroszlai adoroszlai Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

Your link is 404 for me, but I guess this is the original:
https://issues.apache.org/jira/browse/MPOM-132

Updated the patch (and the plugin, because the old version did not support posix mode).

Copy link
Contributor

@kerneltime kerneltime Dec 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, link works for me but yes that is the issue.

@adoroszlai adoroszlai merged commit 984d26a into apache:master Dec 2, 2022
@adoroszlai adoroszlai deleted the HDDS-7562 branch December 2, 2022 16:01
Galsza pushed a commit to Galsza/ozone that referenced this pull request Dec 7, 2022
@adoroszlai @Galsza
HDDS-7562. Suppress warning about long filenames in tar (apache#4017)
83f4bf6
errose28 added a commit to errose28/ozone that referenced this pull request Dec 12, 2022
@errose28
Merge branch 'master' into HDDS-6447
4b35b5e 
* master: (110 commits)
  HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys (apache#3987)
  HDDS-5704. Ozone URI syntax description in help content needs to mention about ozone service id (apache#3862)
  HDDS-7555. Upgrade Ratis to 2.4.2-8b8bdda-SNAPSHOT. (apache#4028)
  HDDS-7541. FSO recursive delete directory with hierarchy takes much time for cleanup (apache#4008)
  HDDS-7581. Fix update-jar-report for snapshot (apache#4034)
  HDDS-7253. Fix exception when '/' in key name (apache#4038)
  HDDS-7579. Use Netty 4.1.77 for consistency (apache#4031)
  HDDS-7562. Suppress warning about long filenames in tar (apache#4017)
  HDDS-7563. Add a handler for under replicated Ratis containers in RM (apache#4025)
  HDDS-7497. Fix mkdir does not update bucket's usedNamespace (apache#3969)
  HDDS-7567. Invalid entries in LICENSE (apache#4020)
  HDDS-7575. Correct showing of RATIS-THREE icon in Recon UI (apache#4026)
  HDDS-7540. Let reusable workflow inherit secrets (apache#4012)
  HDDS-7568. Bump copyright year in NOTICE (apache#4018)
  HDDS-7394. OM RPC FairCallQueue decay decision metrics list caller username in the metric (apache#3878)
  HDDS-7510. Recon: Return number of open containers in `/clusterState` endpoint (apache#3989)
  HDDS-7561. Improve setquota, clrquota CLI usage (apache#4016)
  HDDS-6615. EC: Improve write performance by pipelining encode and flush (apache#3994)
  HDDS-7554. Recon UI should show DORMANT in pipeline status filter (apache#4010)
  HDDS-7540. Separate scheduled CI from push/PR workflows (apache#4004)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerneltime kerneltime kerneltime approved these changes

Assignees

@adoroszlai adoroszlai

Labels

build Pull request that modifies the build process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adoroszlai @kerneltime