HDDS-7503. CLI admin namespace -quota should return whole file system disk capacity consumed by all replicas #3976
Conversation
…ity consumed by all replicas
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
Looks good except for a few import order issues.
Question: Can you help me understand why testQuotaUsage() had the expected quota output even before the fix?
...zone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java
Show resolved
Hide resolved
| import org.apache.hadoop.ozone.recon.spi.impl.OzoneManagerServiceProviderImpl; | ||
| import org.apache.hadoop.ozone.recon.spi.impl.StorageContainerServiceProviderImpl; | ||
| import org.apache.hadoop.ozone.recon.tasks.NSSummaryTaskWithFSO; | ||
| import org.apache.hadoop.ozone.recon.scm.ReconNodeManager; |
There was a problem hiding this comment.
nit: move this line up by one line to correct the import order.
There was a problem hiding this comment.
Actually, this one and the other ReconNodeManager import needs to move more than one line.
...e/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java
Show resolved
Hide resolved
| import org.apache.hadoop.ozone.recon.spi.impl.OzoneManagerServiceProviderImpl; | ||
| import org.apache.hadoop.ozone.recon.spi.impl.StorageContainerServiceProviderImpl; | ||
| import org.apache.hadoop.ozone.recon.tasks.NSSummaryTaskWithLegacy; | ||
| import org.apache.hadoop.ozone.recon.scm.ReconNodeManager; |
There was a problem hiding this comment.
nit: move this line up by one line to correct the import order.
Then next time please open such PR as draft, to skip CI and let reviewers be aware of upcoming changes. Or only open it after the other PR is merged. |
Yes! sure! thank you Atila!! |
jojochuang
left a comment
jojochuang
left a comment
There was a problem hiding this comment.
I think we need to make sure volume and bucket level quota does not change, only the root level quota should change.
yes, agree! |
|
Thanks @DaveTeng0 @adoroszlai |
… disk capacity consumed by all replicas (apache#3976)
3 participants
What changes were proposed in this pull request?
Command ozone admin namespace quota should return whole file system's disk capacity for root/volume/bucket.
(HDFS -df command returns whole file system's disk capacity for directory)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7503
How was this patch tested?
manual test.