Skip to content

Conversation

@tanvipenumudy
Copy link
Contributor

What changes were proposed in this pull request?

Added numFSOBucketCreates metrics to reflect the number of FSO bucket creation requests.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6305

How was this patch tested?

Existing unit tests.

@JyotinderSingh
Copy link
Contributor

Thanks for the contribution @tanvipenumudy! I have added one comment around the metrics. Please check that out.

There seems to be an issue with the formatting, please run ./checkstyle.sh script present in ozone/hadoop-ozone/dev-support/checks directory to find the issues and correct them.

Copy link
Contributor

@siddhantsangwan siddhantsangwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rakeshadr
Copy link
Contributor

rakeshadr commented Feb 16, 2022

Thanks @tanvipenumudy for the contribution.

Thanks @ayushtkn @siddhantsangwan @JyotinderSingh for the reviews.

+1LGTM, Pending CI report.

@rakeshadr rakeshadr merged commit 87ff329 into apache:master Feb 16, 2022
errose28 added a commit to errose28/ozone that referenced this pull request Feb 17, 2022
* master: (43 commits)
  HDDS-6212. SCM Container DB bootstrap on Recon startup for secure cluster (apache#3027)
  HDDS-6234. Repair containers affected by incorrect used bytes and block count. (apache#3042)
  HDDS-6262. ozone insight log stops working after OM DBUpdates message (apache#3044)
  HDDS-6290. operational-state and node-state options in datanode list CLI not working correctly (apache#3105)
  HDDS-6314. ConcurrentModificationException getting SCMContainerMetrics (apache#3101)
  HDDS-6284. Add BlockDeletingService worker size config (apache#3056)
  HDDS-6324. Do not trigger CI by reopening PR (apache#3092)
  HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name (apache#3055)
  HDDS-6331. Remove toString in debug log parameters within SCMCommonPlacementPolicy (apache#3098)
  HDDS-6330. Remove unnecessary duplicate semicolons (apache#3097)
  HDDS-6305: Add metrics - number of FSO bucket creates (apache#3077)
  HDDS-6311. Fix number of keys displayed in Recon Overview. (apache#3081)
  HDDS-6325. Fix interface ClientProtocol methods typo setThreadLocalS3Auth and clearThreadLocalS3Auth (apache#3093)
  HDDS-6322. Fix Recon getting inccorrect sequenceNumber from OM (apache#3090)
  HDDS-5913. Avoid integer overflow when setting dfs.container.ratis.lo… (apache#2785)
  HDDS-6313. Remove replicas in ContainerStateMap when a container is deleted (apache#3086)
  HDDS-6186. Selective checks: skip integration check for unit test changes (apache#3061)
  HDDS-6310. Update json-smart to 2.4.7. (apache#3080)
  HDDS-6190. Cleanup unnecessary datanode id path checks. (apache#2993)
  HDDS-6304. Add enforcer to make sure ozone.version equals project.version (apache#3075)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants