HDDS-6331. Remove toString in debug log parameters within SCMCommonPlacementPolicy #3098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
approved these changes
Feb 16, 2022
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Feb 17, 2022
* master: (43 commits) HDDS-6212. SCM Container DB bootstrap on Recon startup for secure cluster (apache#3027) HDDS-6234. Repair containers affected by incorrect used bytes and block count. (apache#3042) HDDS-6262. ozone insight log stops working after OM DBUpdates message (apache#3044) HDDS-6290. operational-state and node-state options in datanode list CLI not working correctly (apache#3105) HDDS-6314. ConcurrentModificationException getting SCMContainerMetrics (apache#3101) HDDS-6284. Add BlockDeletingService worker size config (apache#3056) HDDS-6324. Do not trigger CI by reopening PR (apache#3092) HDDS-6283. Change ContainerStateMachine ContainerOpExecutor name (apache#3055) HDDS-6331. Remove toString in debug log parameters within SCMCommonPlacementPolicy (apache#3098) HDDS-6330. Remove unnecessary duplicate semicolons (apache#3097) HDDS-6305: Add metrics - number of FSO bucket creates (apache#3077) HDDS-6311. Fix number of keys displayed in Recon Overview. (apache#3081) HDDS-6325. Fix interface ClientProtocol methods typo setThreadLocalS3Auth and clearThreadLocalS3Auth (apache#3093) HDDS-6322. Fix Recon getting inccorrect sequenceNumber from OM (apache#3090) HDDS-5913. Avoid integer overflow when setting dfs.container.ratis.lo… (apache#2785) HDDS-6313. Remove replicas in ContainerStateMap when a container is deleted (apache#3086) HDDS-6186. Selective checks: skip integration check for unit test changes (apache#3061) HDDS-6310. Update json-smart to 2.4.7. (apache#3080) HDDS-6190. Cleanup unnecessary datanode id path checks. (apache#2993) HDDS-6304. Add enforcer to make sure ozone.version equals project.version (apache#3075) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The debug log has "toString()" called on datanode details, which means it must be evaluated before it gets passed into the debug logger. That means this string will always get created even when the log messages is not emitted.
We can just drop the toString part to fix this.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6331
How was this patch tested?
Existing tests