Skip to content

HDDS-6305: Add metrics - number of FSO bucket creates #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakeshadr merged 4 commits into from
Feb 16, 2022
+17 −1
Merged

HDDS-6305: Add metrics - number of FSO bucket creates #3077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
613d9ff
HDDS-6305: Add metrics - number of FSO bucket creates
tanvipenumudy Feb 11, 2022
6e99583
Merge remote-tracking branch 'upstream/master' into HDDS-6305
tanvipenumudy Feb 13, 2022
cb911e1
HDDS-6305: Fixed basic (checkstyle) issue
tanvipenumudy Feb 13, 2022
014c522
Merge remote-tracking branch 'upstream/master' into HDDS-6305
tanvipenumudy Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public class OMMetrics {
private @Metric MutableCounterLong numVolumeInfos;
private @Metric MutableCounterLong numVolumeCheckAccesses;
private @Metric MutableCounterLong numBucketCreates;
private @Metric MutableCounterLong numFSOBucketCreates;
private @Metric MutableCounterLong numVolumeDeletes;
private @Metric MutableCounterLong numBucketInfos;
private @Metric MutableCounterLong numBucketUpdates;
Expand Down Expand Up @@ -306,6 +307,10 @@ public void incNumBucketCreates() {
numBucketCreates.incr();
}

public void incNumFSOBucketCreates() {
numFSOBucketCreates.incr();
}

public void incNumBucketInfos() {
numBucketOps.incr();
numBucketInfos.incr();
Expand Down Expand Up @@ -629,6 +634,11 @@ public long getNumBucketCreates() {
return numBucketCreates.value();
}

@VisibleForTesting
public long getNumFSOBucketCreates() {
return numFSOBucketCreates.value();
}

@VisibleForTesting
public long getNumBucketInfos() {
return numBucketInfos.value();
Expand Down
4 changes: 3 additions & 1 deletion ...anager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
} else {
omBucketInfo = OmBucketInfo.getFromProtobuf(bucketInfo);
}

if (omBucketInfo.getBucketLayout().isFileSystemOptimized()) {
omMetrics.incNumFSOBucketCreates();
}
AuditLogger auditLogger = ozoneManager.getAuditLogger();
OzoneManagerProtocolProtos.UserInfo userInfo = getOmRequest().getUserInfo();

Expand Down
4 changes: 4 additions & 0 deletions ...test/java/org/apache/hadoop/ozone/om/request/bucket/TestOMBucketCreateRequestWithFSO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,15 @@ public void testValidateAndUpdateCacheWithFSO() throws Exception {
String volumeName = UUID.randomUUID().toString();
String bucketName = UUID.randomUUID().toString();

Assert.assertEquals(0, omMetrics.getNumFSOBucketCreates());

OMBucketCreateRequest omBucketCreateRequest = doPreExecute(volumeName,
bucketName);

doValidateAndUpdateCache(volumeName, bucketName,
omBucketCreateRequest.getOmRequest());

Assert.assertEquals(1, omMetrics.getNumFSOBucketCreates());
}

private OMBucketCreateRequest doPreExecute(String volumeName,
Expand Down