HDDS-5740. Enable ratis by default for SCM. #2637

bshashikant · 2021-09-14T09:10:23Z

What changes were proposed in this pull request?

Enable ratis by default for SCM.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5740

How was this patch tested?

Existing Uts

guihecheng · 2021-09-15T03:16:34Z

Hi @bshashikant the patch itself looks good and I think this is to say that SCM-HA is a stable and production ready from now on.
Actually we've got a benchmark tool for SCM throughput and by using it we detected and fixed a serious throughput degradation on the ratis side these days.
FYI:
https://issues.apache.org/jira/browse/HDDS-5702
https://issues.apache.org/jira/browse/HDDS-5703

So IMHO, we could consider bump up the ratis version sometime(maybe the next release?), so we could have a more stable SCM-HA, thanks~
cc @JacksonYao287

errose28 · 2021-10-25T17:19:23Z

@guihecheng We have recently bumped Ratis to 2.2.0 on master fyi

guihecheng · 2021-10-26T02:35:49Z

@guihecheng We have recently bumped Ratis to 2.2.0 on master fyi

Ah, that's a good news, thanks~

hadoop-ozone/dist/src/main/compose/upgrade/compose/ha/docker-config

mukul1987

+1, LGTM

adoroszlai

Thanks @bshashikant for working on this. I have a question about upgrades, and a minor code change request regarding imports.

adoroszlai · 2022-01-05T08:32:35Z

hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java

 import static org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos.SCMRegisteredResponseProto.ErrorCode.success;
-import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_PIPELINE_AUTO_CREATE_FACTOR_ONE;
-import static org.apache.hadoop.hdds.scm.ScmConfigKeys.OZONE_SCM_RATIS_PIPELINE_LIMIT;
+import static org.apache.hadoop.hdds.scm.ScmConfigKeys.*;


We should avoid star import. (Also in a few other files.)

adoroszlai · 2022-01-05T08:32:38Z

hadoop-ozone/dist/src/main/compose/upgrade/compose/ha/docker-config

+// setting ozone.scm.ratis.enable to false for now, as scm ha upgrade is
+// not supported yet. This is supposed to work without SCM HA configuration
+OZONE-SITE.XML_ozone.scm.ratis.enable=false


If upgrade to SCM HA is not yet supported, why are we enabling it by default? Shouldn't we implement upgrade first, then enable by default?

My concern is this: consider a non SCM HA cluster, where ozone.scm.ratis.enable=false comes from the default config. If upgraded, will SCM HA now be suddenly enabled after upgrade? Will the admin need to disable SCM HA manually to make it work?

this is safe to use, in case of non HA, it should just startup a single node ratis server. This needs to be enabled, so as to make sure the the tests excercise the HA path, not the standalone path.

@REPLicated

…ansport support (#3074) * HDDS-6149. Remove unused keytabs (#2960) * HDDS-6094. Some unit tests are skipped due to using JUnit4 runner (#2909) * HDDS-6075. OzoneConfiguration constructor overrides input configuration keys. (#2921) * HDDS-4177. SCM Container DB bootstrap on Recon startup (#2942) * HDDS-6086. Compute MD5MD5CRC file checksum using chunk checksums from DataNodes (#2919) * HDDS-6148. Validate ContainerBalancerConfiguration before start ContainerBalancer (#2957) * HDDS-6161. SCM StateMachine failing to reinitialize doesn't terminate the process. (#2971) * HDDS-6134. Move replication-specific config to ReplicationServer (#2943) * HDDS-4010. S3G startup fails when multiple service ids are configured. (#2976) * HDDS-6170. Add metrics to replication manager to track container health states (#2975) * HDDS-3231. Cleanup KeyManagerImpl (#2961) * HDDS-5927. Improve defaults in ContainerBalancerConfiguration (#2892) * HDDS-6157. More consistent synchronization in InputStreams (#2965) * HDDS-4743. [FSO] Add FSO variant of ITestOzoneContractDistcp. (#2980) * HDDS-6114. Intermittent error due to Failed to init RocksDB (#2947) * HDDS-6175. Use s3Auth during proxy during decrypt in RpcClient. (#2981) * HDDS-6175. Use s3Auth during proxy during decrypt in RpcClient. * HDDS-5740. Enable ratis by default for SCM. (#2637) * HDDS-6183. Intermittent failure in TestKeyDeletingService.checkIfDeleteServiceWithFailingSCM. (#2991) * HDDS-4190. Intermittent failure in TestOMVolumeSetOwnerRequest and TestOMVolumeSetQuotaRequest. (#2982) * HDDS-6120. Compute block checksum using chunk checksums (#2930) * HDDS-6147. Add ability in OM to get limited delta updates (#2956) * HDDS-6195. Remove unused jmh-core dependency. (#2997) * HDDS-6167. Update ozone-runner version to 20211202-1 (#2969) * HDDS-6171. Create an API to change Bucket Owner (#2988) * HDDS-6163. Fix PATH in docker image (#2967) * HDDS-6202. Avoid using jmh-generator-annprocess since it is GPL2.0. (#2998) * HDDS-6135. SCM Container DB bootstrap on Recon startup for SCM HA. (#2972) * HDDS-6109. Preserve the underlying exception raised in client lib. (#2989) * HDDS-3408. Rename ChunkLayOutVersion to ContainerLayoutVersion. (#2983) * HDDS-6203. CleanUp incomplete gz files during Container move (#3000) * HDDS-6216. Move OMOpenKeysDeleteRequest to package om.request.key (#3011) * HDDS-6191. Intermittent failure in TestDeleteWithSlowFollower (#3015) * HDDS-6128. CLI tool that downloads all the block replicas and creates a manifest file (#2987) * HDDS-6177. Extend container info command to include replica details (#2995) * HDDS-6211. [Docs] Image styling on deployed site does not replicate local builds. (#3007) * HDDS-6219. Switch to RATIS ReplicationType from STAND_ALONE in our tests. (#3014) * HDDS-6192. feature/Observability.md translated to Chinese (#2994) * HDDS-6205. Add CLI command to display the latest Replication Manager report (#3013) * HDDS-6227. Test helpers should observe naming conditions (#3020) * HDDS-6239. ozonesecure-mr failing with No URLs in mirrorlist (#3029) * HDDS-6201. Fix NPE for DataScanner with scanned container deleted by others. (#3005) * HDDS-5529. For any IOexception from @REPLicated method we should throw it (#2788) * HDDS-6181. Change SCMHAInvocationHandler#invokeRatis() logging to TRACE (#2992) * HDDS-6206. Application errors must not flood system log (#3001) * HDDS-6245. Add BucketLayout logging to Audit Logs (#3040) * HDDS-6238 Reduce memory requirements for list keys. (#3032) * HDDS-2919. Intermittent failure in TestRDBStore (#3028) * HDDS-6253. Unnecessary duplicate smoketest after defaulting to FSO (#3036) * HDDS-6204. Cleanup handling malformed authorization header (#2999) * HDDS-6169. Selective checks: skip junit tests on ozone-runner image update (#2974) * HDDS-6270. Use a dedicated file instead of /etc/passwd for xcompat acceptance test (#3050) * HDDS-6273. Amend doc SecuringTDE.md (#3047) * HDDS-6140. Selective checks: skip unit check for integration-test changes (#2948) * HDDS-6215. Recon get limited delta updates from OM (#3009) * HDDS-6125. Recon get limited delta updates from OM * HDDS-6215. Fix unit test * trigger new CI check * HDDS-6215. Fix typo * trigger new CI check Co-authored-by: Symious <[email protected]> * HDDS-6226. Run tests for selective CI checks in CI (#3019) * HDDS-6247. Avoid logging stack trace for user input problems (#3039) * HDDS-6208. New checkstyle: WhitespaceAround (#3003) * HDDS-6289. Upgrade acceptance test log flooded with parse error (#3063) Co-authored-by: Siyao Meng <[email protected]> * Trigger Build * Fix integration test for added configuation field for selecting OmTransport for s3 gateway - TestOzoneConfigurationFields (added config key not in xml). Co-authored-by: Doroszlai, Attila <[email protected]> Co-authored-by: Lokesh Jain <[email protected]> Co-authored-by: Aswin Shakil Balasubramanian <[email protected]> Co-authored-by: Wei-Chiu Chuang <[email protected]> Co-authored-by: Symious <[email protected]> Co-authored-by: Bharat Viswanadham <[email protected]> Co-authored-by: Stephen O'Donnell <[email protected]> Co-authored-by: GeorgeJahad <[email protected]> Co-authored-by: Siddhant Sangwan <[email protected]> Co-authored-by: Jyotinder Singh <[email protected]> Co-authored-by: Shashikant Banerjee <[email protected]> Co-authored-by: Tsz-Wo Nicholas Sze <[email protected]> Co-authored-by: Kiyoshi Mizumaru <[email protected]> Co-authored-by: Ritesh H Shukla <[email protected]> Co-authored-by: Nibiru <[email protected]> Co-authored-by: Kaijie Chen <[email protected]> Co-authored-by: Zita Dombi <[email protected]> Co-authored-by: Istvan Fajth <[email protected]> Co-authored-by: steinsgateted <[email protected]> Co-authored-by: Gui Hecheng <[email protected]> Co-authored-by: Jackson Yao <[email protected]> Co-authored-by: Keyi Song <[email protected]> Co-authored-by: UENISHI Kota <[email protected]> Co-authored-by: Siyao Meng <[email protected]> Co-authored-by: Symious <[email protected]>

This reverts commit 3eb7235.

bshashikant requested review from mukul1987 and nandakumar131 September 14, 2021 09:10

bshashikant force-pushed the HDDS-5740 branch from 9fc1422 to 59cab18 Compare November 18, 2021 08:37

bshashikant force-pushed the HDDS-5740 branch 2 times, most recently from c0f6484 to 2a09440 Compare December 3, 2021 10:23

mukul1987 reviewed Dec 10, 2021

View reviewed changes

hadoop-ozone/dist/src/main/compose/upgrade/compose/ha/docker-config Outdated Show resolved Hide resolved

bshashikant added 19 commits December 16, 2021 12:13

HDDS-5740. Enable ratis by default for SCM.

211f132

Addressed UT failures.

36b23bc

Trigger CI check

ffd0341

Fixing unit tests.

77831f5

Fixing unit tests.

21faf49

Trigger CI check

ccea4d9

Fixed test failures.

54fc0f0

Fixed test failures.

c00a47f

Addressed review comments.

0c1632f

Addressed UT falures.

52ee97a

Addressed UT falures.

e50f92c

Addressed UT falures.

f715fb5

Address unit test failures.

14e8bc7

Fixed UT failures.

9393f42

Trigger CI check

d0c4f21

Addressed UT failures.

3224382

Addressed review comments.

4b0014d

Trigger CI check

11feace

Trigger CI check

c61cbd7

bshashikant force-pushed the HDDS-5740 branch from 1ceb1b3 to c61cbd7 Compare December 16, 2021 06:46

Trigger CI check

811c7e3

mukul1987 approved these changes Jan 5, 2022

View reviewed changes

adoroszlai requested changes Jan 5, 2022

View reviewed changes

bshashikant merged commit 3eb7235 into apache:master Jan 13, 2022

adoroszlai added a commit to adoroszlai/ozone that referenced this pull request Apr 28, 2022

Revert "HDDS-5740. Enable ratis by default for SCM. (apache#2637)"

11bb95e

This reverts commit 3eb7235.

adoroszlai mentioned this pull request Apr 28, 2022

Revert "HDDS-5740. Enable ratis by default for SCM." #3362

Merged

adoroszlai added a commit that referenced this pull request May 3, 2022

Revert "HDDS-5740. Enable ratis by default for SCM. (#2637)" (#3362)

e70bfd0

This reverts commit 3eb7235.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDDS-5740. Enable ratis by default for SCM. #2637

HDDS-5740. Enable ratis by default for SCM. #2637

Uh oh!

bshashikant commented Sep 14, 2021

Uh oh!

guihecheng commented Sep 15, 2021 •

edited

Loading

Uh oh!

errose28 commented Oct 25, 2021

Uh oh!

guihecheng commented Oct 26, 2021

Uh oh!

Uh oh!

mukul1987 left a comment

Uh oh!

adoroszlai left a comment

Uh oh!

adoroszlai Jan 5, 2022

Uh oh!

adoroszlai Jan 5, 2022

Uh oh!

bshashikant Jan 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

HDDS-5740. Enable ratis by default for SCM. #2637

HDDS-5740. Enable ratis by default for SCM. #2637

Uh oh!

Conversation

bshashikant commented Sep 14, 2021

What changes were proposed in this pull request?

What is the link to the Apache JIRA

How was this patch tested?

Uh oh!

guihecheng commented Sep 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

errose28 commented Oct 25, 2021

Uh oh!

guihecheng commented Oct 26, 2021

Uh oh!

Uh oh!

mukul1987 left a comment

Choose a reason for hiding this comment

Uh oh!

adoroszlai left a comment

Choose a reason for hiding this comment

Uh oh!

adoroszlai Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

adoroszlai Jan 5, 2022

Choose a reason for hiding this comment

Uh oh!

bshashikant Jan 13, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guihecheng commented Sep 15, 2021 •

edited

Loading