-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-5740. Enable ratis by default for SCM. #2637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
211f132
36b23bc
ffd0341
77831f5
21faf49
ccea4d9
54fc0f0
c00a47f
0c1632f
52ee97a
e50f92c
f715fb5
14e8bc7
9393f42
d0c4f21
3224382
4b0014d
11feace
c61cbd7
811c7e3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,9 @@ OZONE-SITE.XML_ozone.om.address.omservice.om1=om1 | |
| OZONE-SITE.XML_ozone.om.address.omservice.om2=om2 | ||
| OZONE-SITE.XML_ozone.om.address.omservice.om3=om3 | ||
| OZONE-SITE.XML_ozone.om.ratis.enable=true | ||
|
|
||
| // setting ozone.scm.ratis.enable to false for now, as scm ha upgrade is | ||
| // not supported yet. This is supposed to work without SCM HA configuration | ||
| OZONE-SITE.XML_ozone.scm.ratis.enable=false | ||
bshashikant marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Comment on lines
+27
to
+29
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If upgrade to SCM HA is not yet supported, why are we enabling it by default? Shouldn't we implement upgrade first, then enable by default? My concern is this: consider a non SCM HA cluster, where
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is safe to use, in case of non HA, it should just startup a single node ratis server. This needs to be enabled, so as to make sure the the tests excercise the HA path, not the standalone path. |
||
| OZONE-SITE.XML_ozone.scm.pipeline.creation.interval=30s | ||
| OZONE-SITE.XML_ozone.scm.pipeline.owner.container.count=1 | ||
| OZONE-SITE.XML_ozone.scm.names=scm | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid star import. (Also in a few other files.)