Skip to content

HDDS-5021 dev-support Dockerfile is badly outdated #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adoroszlai merged 5 commits into from
Aug 10, 2021
Merged

HDDS-5021 dev-support Dockerfile is badly outdated #2480

adoroszlai merged 5 commits into from
Aug 10, 2021

Conversation

@jwminton
Copy link
Contributor

@jwminton jwminton commented Jul 30, 2021

What changes were proposed in this pull request?

  • To satisfy docker-compose requirements, the following apk packages were added:
    python3-dev libffi-dev openssl-dev gcc libc-dev rust cargo make
    All (yes, even rust) required according to docker compose doc: https://docs.docker.com/compose/install/#install-using-pip
  • bumped the glibc package version
  • removed protobuf installation
  • replaced findbugs install with spotbugs per jira request
  • bumped the ant version
  • Changed the 'git clone...' operation to reference ozone.git while mirroring what was done before (previously used 'trunk' ozone uses 'master')
  • pom.xml and the plugin version -- The plugin that installs a local version of node for the recon build needed its version to be bumped because of changes to the latest version of alpine/node/glibc/compatibility/etc. The old version causes libstdc++ library to not be found by node during the recon build, despite being installed. Latest plugin with the latest alpine works fine. Note that this docker image won't work until the ozone master version of pom.xml has the updated version number. For testing I was using a sed line to change it in place:
    cd /tmp/ozone &&
    sed -i '/<frontend-maven-plugin.version>/ s/1.10/1.12/' pom.xml &&
    mvn package dependency:go-offline -DskipTests -pl :ozone-dist -am &&
    I assume it will be ok once both of these changes go in at the same time.
  • For the final mvn call, there was a '-P hdds' option that is no longer a valid profile and causes a warning. I removed it to prevent the warning, but I'm not sure if it should have been replaced with something else.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5021

How was this patch tested?

Manual tests and manual docker image creation

adoroszlai
adoroszlai requested changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwminton for updating the Dockerfile. The patch mostly looks good, I noticed only one place where it is still outdated. I have to admit I couldn't yet build the image completely, so I might have missed some problems.

jwminton and others added 2 commits July 31, 2021 18:17
adoroszlai
adoroszlai approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwminton for updating the patch.

@adoroszlai adoroszlai merged commit d51bd4b into apache:master Aug 10, 2021
errose28 added a commit to errose28/ozone that referenced this pull request Aug 12, 2021
@errose28
Merge branch 'master' into HDDS-4183
bbd88d4 
* master:
  HDDS-5358. Incorrect cache entry invalidation causes intermittent failure in testGetS3SecretAndRevokeS3Secret (apache#2518)
  HDDS-5608. Fix wrong command in ugrade doc (apache#2524)
  HDDS-5000. Run CI checks selectively (apache#2479)
  HDDS-4929. Select target datanodes and containers to move for Container Balancer (apache#2441)
  HDDS-5283. getStorageSize cast to int can cause issue (apache#2303)
  HDDS-5449 Recon namespace summary 'du' information should return replicated size of a key (apache#2489)
  HDDS-5558. vUnit invocation unit() may produce NPE (apache#2513)
  HDDS-5531. For Link Buckets avoid showing metadata. (apache#2502)
  HDDS-5549. Add 1.1 to supported versions in security policy (apache#2519)
  HDDS-5555. remove pipeline manager v1 code (apache#2511)
  HDDS-5546.OM Service ID change causes OM startup failure. (apache#2512)
  HDDS-5360. DN failed to process all delete block commands in one heartbeat interval (apache#2420)
  HDDS-5021. dev-support Dockerfile is badly outdated (apache#2480)
errose28 added a commit to errose28/ozone that referenced this pull request Aug 12, 2021
@errose28
Merge branch 'master' into HDDS-5601
7473adf 
* master:
  HDDS-5358. Incorrect cache entry invalidation causes intermittent failure in testGetS3SecretAndRevokeS3Secret (apache#2518)
  HDDS-5608. Fix wrong command in ugrade doc (apache#2524)
  HDDS-5000. Run CI checks selectively (apache#2479)
  HDDS-4929. Select target datanodes and containers to move for Container Balancer (apache#2441)
  HDDS-5283. getStorageSize cast to int can cause issue (apache#2303)
  HDDS-5449 Recon namespace summary 'du' information should return replicated size of a key (apache#2489)
  HDDS-5558. vUnit invocation unit() may produce NPE (apache#2513)
  HDDS-5531. For Link Buckets avoid showing metadata. (apache#2502)
  HDDS-5549. Add 1.1 to supported versions in security policy (apache#2519)
  HDDS-5555. remove pipeline manager v1 code (apache#2511)
  HDDS-5546.OM Service ID change causes OM startup failure. (apache#2512)
  HDDS-5360. DN failed to process all delete block commands in one heartbeat interval (apache#2420)
  HDDS-5021. dev-support Dockerfile is badly outdated (apache#2480)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kerneltime kerneltime kerneltime approved these changes

@adoroszlai adoroszlai adoroszlai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jwminton @kerneltime @adoroszlai