HDDS-5283. getStorageSize cast to int can cause issue #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadanand48
changed the title
adoroszlai
previously requested changes
Jun 4, 2021
...a/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
Outdated
Show resolved
Hide resolved
adoroszlai
dismissed
their stale review
Thanks @sadanand48 for updating the patch
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
And also I see there are other usages of getStorageSize where we convert to INT, Can you take care of those also?
...java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java
Outdated
Show resolved
Hide resolved
...a/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
Outdated
Show resolved
Hide resolved
Contributor
|
@sadanand48 , can you please rebase? |
added 14 commits
July 27, 2021 09:34
mukul1987
requested changes
Aug 4, 2021
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/HddsUtils.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 5, 2021 21:24
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Aug 12, 2021
* master: HDDS-5358. Incorrect cache entry invalidation causes intermittent failure in testGetS3SecretAndRevokeS3Secret (apache#2518) HDDS-5608. Fix wrong command in ugrade doc (apache#2524) HDDS-5000. Run CI checks selectively (apache#2479) HDDS-4929. Select target datanodes and containers to move for Container Balancer (apache#2441) HDDS-5283. getStorageSize cast to int can cause issue (apache#2303) HDDS-5449 Recon namespace summary 'du' information should return replicated size of a key (apache#2489) HDDS-5558. vUnit invocation unit() may produce NPE (apache#2513) HDDS-5531. For Link Buckets avoid showing metadata. (apache#2502) HDDS-5549. Add 1.1 to supported versions in security policy (apache#2519) HDDS-5555. remove pipeline manager v1 code (apache#2511) HDDS-5546.OM Service ID change causes OM startup failure. (apache#2512) HDDS-5360. DN failed to process all delete block commands in one heartbeat interval (apache#2420) HDDS-5021. dev-support Dockerfile is badly outdated (apache#2480)
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Aug 12, 2021
* master: HDDS-5358. Incorrect cache entry invalidation causes intermittent failure in testGetS3SecretAndRevokeS3Secret (apache#2518) HDDS-5608. Fix wrong command in ugrade doc (apache#2524) HDDS-5000. Run CI checks selectively (apache#2479) HDDS-4929. Select target datanodes and containers to move for Container Balancer (apache#2441) HDDS-5283. getStorageSize cast to int can cause issue (apache#2303) HDDS-5449 Recon namespace summary 'du' information should return replicated size of a key (apache#2489) HDDS-5558. vUnit invocation unit() may produce NPE (apache#2513) HDDS-5531. For Link Buckets avoid showing metadata. (apache#2502) HDDS-5549. Add 1.1 to supported versions in security policy (apache#2519) HDDS-5555. remove pipeline manager v1 code (apache#2511) HDDS-5546.OM Service ID change causes OM startup failure. (apache#2512) HDDS-5360. DN failed to process all delete block commands in one heartbeat interval (apache#2420) HDDS-5021. dev-support Dockerfile is badly outdated (apache#2480)
adoroszlai
reviewed
Aug 16, 2021
|
|
||
| <!-- Apache Ratis version --> | ||
| <ratis.version>2.1.0</ratis.version> | ||
| <ratis.version>2.1.0-03f3b68-SNAPSHOT</ratis.version> |
Contributor
There was a problem hiding this comment.
Sorry, but this seems to be wrong. Ratis 2.1.0 is already released, we cannot have a new snapshot version for it. I think we should go for a new 2.1.1 release with RATIS-1384 (and RATIS-1386) bugfix.
Contributor
|
@mukul1987 @adoroszlai Hi compile fails because of @adoroszlai 's last comments. Should we change the ratis version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
value of
pendingRequestsByteLimitcouldn’t be set beyond 2GB because of the integer limit. Similarly there were other places where getStorageSize was cast to int. Converted to long where possible and changed the scale of the variable if not.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5283
How was this patch tested?
CI