HDDS-4358: Delete : make delete an atomic operation #1607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linyiqun
reviewed
Nov 20, 2020
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
Thank You @rakeshadr for the PR.
Few comments inline.
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
Outdated
Show resolved
Hide resolved
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequestV1.java
Outdated
Show resolved
Hide resolved
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequestV1.java
Show resolved
Hide resolved
...one-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMKeyDeleteResponseV1.java
Outdated
Show resolved
Hide resolved
...p-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemV1.java
Show resolved
Hide resolved
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
Show resolved
Hide resolved
Contributor
|
And also as discussed offline from S3G interface/Shell |
Contributor
Author
|
@bharatviswa504 updated patch by addressing your comments. Please let me know your feedback. Thanks! |
linyiqun
reviewed
Dec 4, 2020
Contributor
linyiqun
left a comment
linyiqun
left a comment
There was a problem hiding this comment.
The latest PR almost looks good. Please have a look for my minor comments below, @rakeshadr .
...ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
Show resolved
Hide resolved
...ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java
Show resolved
Hide resolved
linyiqun
reviewed
Dec 4, 2020
...p-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemV1.java
Show resolved
Hide resolved
linyiqun
approved these changes
Dec 6, 2020
Contributor
linyiqun
left a comment
linyiqun
left a comment
There was a problem hiding this comment.
+1. Thanks for addressing the comments, @rakeshadr .
Contributor
Author
|
Thanks @linyiqun and @bharatviswa504 for the useful review comments. I'll merge this shortly. |
rakeshadr
added a commit
that referenced
this pull request
Dec 7, 2020
rakeshadr
added a commit
that referenced
this pull request
Jan 6, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 11, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 13, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 25, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 28, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 1, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 1, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 3, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 5, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 15, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 18, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 25, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 3, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 9, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 27, 2021
rakeshadr
added a commit
that referenced
this pull request
Apr 7, 2021
rakeshadr
added a commit
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This task handles directory and file deletions. This won't cleanup the garbage and orphans which will be implemented in another jira.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4358
How was this patch tested?
TestOzoneFileSystemV1 suite