HDDS-4514. AllocateBlock : lookup and update open file table for the given path #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le entry into separate FileTable (apache#1473)
…try in dir/file table (apache#1557) HDDS-4357: Rename : make rename an atomic ops by updating key path entry in dir/file table
linyiqun
reviewed
Dec 4, 2020
Contributor
linyiqun
left a comment
linyiqun
left a comment
There was a problem hiding this comment.
The change looks good to me. Below some minor comments from me.
| } | ||
| Assert.assertFalse("key already exists /root_dir/file1", | ||
| fs.rename(abcRootPath, file1Destin)); | ||
| } |
Contributor
There was a problem hiding this comment.
Above rename related change already contained in PR #1607.
Contributor
Author
| */ | ||
| public class TestOMAllocateBlockResponseV1 | ||
| extends TestOMAllocateBlockResponse { | ||
|
|
Contributor
There was a problem hiding this comment.
Do we need to override getOzoneConfiguration method in this class?
protected OzoneConfiguration getOzoneConfiguration() {
OzoneConfiguration config = super.getOzoneConfiguration();
config.set(OMConfigKeys.OZONE_OM_LAYOUT_VERSION, "V1");
return config;
}
Contributor
Author
There was a problem hiding this comment.
Contributor
|
@rakeshadr can you rebase this PR, it has multiple changes looks like it. |
Contributor
Author
|
Current PR has multiple changes and looks like stale. I am closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This task is to use open file table for the allocate block operations. This has been identified as part of Hive TPCDS benchmark test.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4514
How was this patch tested?
Added UT cases. Also, verified by running hive tpcds test