HDDS-4321. Fix compilation errors : merge HDDS-4308 and HDDS-4473 changes into the branch #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukul1987
reviewed
Dec 7, 2020
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
Show resolved
Hide resolved
linyiqun
reviewed
Dec 7, 2020
Contributor
There was a problem hiding this comment.
Besides @mukul1987 's comment, volume quota change in OMFileCreateResponseV1 also needed to update,OMFileCreateResponseV1.java#L82
Contributor
Author
Thanks @linyiqun for the comment. Will update it. |
...ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyDeleteRequestV1.java
Show resolved
Hide resolved
rakeshadr
changed the title
Contributor
|
As this is blocking further PR's and it is only a compilation issue fix, and anyway, quota will be revisited, I am fine with this PR going in. |
Contributor
Author
|
Thanks @mukul1987 , @linyiqun , @bharatviswa504 for the reviews. I will merge it. |
rakeshadr
changed the title
rakeshadr
added a commit
that referenced
this pull request
Dec 9, 2020
rakeshadr
changed the title
rakeshadr
added a commit
that referenced
this pull request
Jan 6, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 11, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 13, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 25, 2021
rakeshadr
added a commit
that referenced
this pull request
Jan 28, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 1, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 1, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 3, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 5, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 15, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 18, 2021
rakeshadr
added a commit
that referenced
this pull request
Feb 25, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 3, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 9, 2021
rakeshadr
added a commit
that referenced
this pull request
Mar 27, 2021
rakeshadr
added a commit
that referenced
this pull request
Apr 7, 2021
rakeshadr
added a commit
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is to fix compilation errors by merging HDDS-4308 and HDDS-4473 changes to the branch.
Need to revisit all the newly created "*RequestV1.java" and "*ResponseV1.java" classes and incorporate HDDS-4308 changes into it. Also, KeyManagerImpl class.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4321
How was this patch tested?
Existing V1 UT cases.