-
Notifications
You must be signed in to change notification settings - Fork 587
HDDS-4088. Adding Owner info for Authorizer plugin to honor owner access rights #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smengcl
reviewed
Oct 22, 2020
Contributor
smengcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaoyuyao for the patch. Overall lgtm.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
smengcl
reviewed
Oct 22, 2020
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
smengcl
approved these changes
Oct 26, 2020
Contributor
smengcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm+1
Contributor
Author
|
Thanks @smengcl for the review. |
ayushtkn
pushed a commit
to ayushtkn/hadoop-ozone
that referenced
this pull request
Oct 31, 2020
* HDDS-1577. Add default pipeline placement policy implementation. (apache#1366) (cherry picked from commit b640a5f6d53830aee4b9c2a7d17bf57c987962cd) * HDDS-1571. Create an interface for pipeline placement policy to support network topologies. (apache#1395) (cherry picked from commit 753fc6703a39154ed6013e44dbae572391748906) * HDDS-2089: Add createPipeline CLI. (apache#1418) (cherry picked from commit 326b5acd4a63fe46821919322867f5daff30750c) * HDDS-1569 Support creating multiple pipelines with same datanode. Contributed by Li Cheng. This closes apache#28 * HDDS-1572 Implement a Pipeline scrubber to clean up non-OPEN pipeline. (apache#237) * Rebase Fix * HDDS-2650 Fix createPipeline CLI. (apache#340) * HDDS-2035 Implement datanode level CLI to reveal pipeline relation. (apache#348) * Revert "HDDS-2650 Fix createPipeline CLI. (apache#340)" This reverts commit 7c71710. * HDDS-2650 Fix createPipeline CLI and make it message based. (apache#370) * HDDS-1574 Average out pipeline allocation on datanodes and add metrcs/test (apache#291) * Resolve rebase conflict. * HDDS-2756. Handle pipeline creation failure in different way when it exceeds pipeline limit Closes apache#401 * HDDS-2115 Add acceptance test for createPipeline CLI and datanode list CLI (apache#375) * HDDS-2115 Add acceptance test for createPipeline CLI and datanode list CLI. * HDDS-2772 Better management for pipeline creation limitation. (apache#410) * HDDS-2913 Update config names and CLI for multi-raft feature. (apache#462) * HDDS-2924. Fix Pipeline#nodeIdsHash collision issue. (apache#478) * HDDS-2923 Add fall-back protection for rack awareness in pipeline creation. (apache#516) * HDDS-3007 Fix CI test failure for TestSCMNodeManager. (apache#550) Co-authored-by: Sammi Chen <[email protected]> Co-authored-by: Xiaoyu Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
adding isowner flag and volume owner info to acl check request context so that Ranger and 3rd party plugin can allow volume owner has full control over the volume
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4088
How was this patch tested?
UT added.