HDDS-7240. List all volume operation should go through ACL check as well in order to trigger audit logging #3770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I48d7d60c84bdf73ac2101c1dd711cad2badfe5b2
Change-Id: I06ef015cf06b7b5382f1df481886e95c74d64abb
smengcl
approved these changes
Sep 21, 2022
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
+1 pending CI. Thanks @dombizita
Contributor
|
cc @duongkame |
duongkame
approved these changes
Sep 21, 2022
Contributor
duongkame
left a comment
duongkame
left a comment
There was a problem hiding this comment.
+1, thanks @dombizita for the patch.
Contributor
|
Thanks @dombizita for the patch. Thanks @duongkame for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously the list all volume operation only went through the ACL check if the list all volume was disabled. Because of this the audit logging wasn't triggered. I removed the if condition checking the
ozone.om.volume.listall.allowed's value, so the ACL check gets triggered in every case (if the ACL is enabled). I also updated theozone.om.volume.listall.allowed's description inozone-default.xml.OzoneNativeAuthorizer wouldn't be affected by this change, because of this change, the allowListAllVolumes is set here on the authorizer side.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7240
How was this patch tested?
Run related tests.