Skip to content

Conversation

@timmylicheng
Copy link
Contributor

What changes were proposed in this pull request?

#HDDS-2772
Better default value for OZONE_SCM_PIPELINE_NUMBER_LIMIT and OZONE_DATANODE_MAX_PIPELINE_ENGAGEMENT

and update some ut acoordingly

(Please fill in changes proposed in this fix)

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-2772

(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

UT
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

@timmylicheng timmylicheng force-pushed the HDDS-2772 branch 2 times, most recently from 5318bb2 to 735f317 Compare January 8, 2020 08:28
@ChenSammi
Copy link
Contributor

Suggest change OZONE_DATANODE_MAX_PIPELINE_ENGAGEMENT_DEFAULT to 2, keeping the same hehavior as current single pipeline case.

@timmylicheng
Copy link
Contributor Author

Suggest change OZONE_DATANODE_MAX_PIPELINE_ENGAGEMENT_DEFAULT to 2, keeping the same hehavior as current single pipeline case.

Sure. I've set the default to 2. Now users have to override the number in ozone-site.xml in order to turn on multi-raft.

@ChenSammi
Copy link
Contributor

+1.

@ChenSammi ChenSammi merged commit 2ebf21b into apache:HDDS-1564 Jan 10, 2020
@timmylicheng timmylicheng deleted the HDDS-2772 branch January 22, 2020 07:36
timmylicheng added a commit to timmylicheng/hadoop-ozone that referenced this pull request Feb 10, 2020
timmylicheng added a commit to timmylicheng/hadoop-ozone that referenced this pull request Feb 12, 2020
anuengineer pushed a commit that referenced this pull request Feb 19, 2020
* HDDS-1577. Add default pipeline placement policy implementation. (#1366)



(cherry picked from commit b640a5f6d53830aee4b9c2a7d17bf57c987962cd)

* HDDS-1571. Create an interface for pipeline placement policy to support network topologies. (#1395)

(cherry picked from commit 753fc6703a39154ed6013e44dbae572391748906)

* HDDS-2089: Add createPipeline CLI. (#1418)

(cherry picked from commit 326b5acd4a63fe46821919322867f5daff30750c)

* HDDS-1569 Support creating multiple pipelines with same datanode. Contributed by Li Cheng. 

This closes #28

* HDDS-1572 Implement a Pipeline scrubber to clean up non-OPEN pipeline. (#237)

* Rebase Fix

* HDDS-2650 Fix createPipeline CLI. (#340)

* HDDS-2035 Implement datanode level CLI to reveal pipeline relation. (#348)

* Revert "HDDS-2650 Fix createPipeline CLI. (#340)"

This reverts commit 7c71710.

* HDDS-2650 Fix createPipeline CLI and make it message based. (#370)

* HDDS-1574 Average out pipeline allocation on datanodes and add metrcs/test (#291)

* Resolve rebase conflict.

* HDDS-2756. Handle pipeline creation failure in different way when it exceeds pipeline limit

Closes #401

* HDDS-2115 Add acceptance test for createPipeline CLI and datanode list CLI (#375)

* HDDS-2115 Add acceptance test for createPipeline CLI and datanode list CLI.

* HDDS-2772 Better management for pipeline creation limitation. (#410)

*  HDDS-2913 Update config names and CLI for multi-raft feature. (#462)

* HDDS-2924. Fix Pipeline#nodeIdsHash collision issue. (#478)

* HDDS-2923 Add fall-back protection for rack awareness in pipeline creation. (#516)

* HDDS-3007 Fix CI test failure for TestSCMNodeManager. (#550)

Co-authored-by: Sammi Chen <[email protected]>
Co-authored-by: Xiaoyu Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants