Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Refactor onnx tests for object classification, add object detection tests #19802

Merged
merged 12 commits into from
Feb 2, 2021
Merged

[v1.x] Refactor onnx tests for object classification, add object detection tests #19802

merged 12 commits into from
Feb 2, 2021

Conversation

josephevans
Copy link
Contributor

Description

Refactor onnx tests for object classification, add object detection tests.
Also fix a few ONNX export operators:

  • SliceChannel and add unit test
  • broadcast_equal add add unit test
  • zeros_likes
  • ones_like
  • arange (update unit test)
  • broadcast_mod (set name attribute)

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, centos-cpu, clang, unix-cpu, website, unix-gpu, edge, centos-gpu, windows-gpu, sanity, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 29, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 29, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jan 29, 2021
Zha0q1
Zha0q1 reviewed Jan 30, 2021
View reviewed changes
tests/python-pytest/onnx/test_onnxruntime.py
res = softmax(np.array(raw_result)).tolist()
class_idx = np.argmax(res)
assert(class_idx in accepted_ids)
test_image_urls = ['https://raw.githubusercontent.com/zhreshold/mxnet-ssd/master/data/demo/dog.jpg']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we consider adding more test images?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we will soon in upcoming PRs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should have tests which avoid depending on extrenal sources

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In upcoming PRs for these onnxruntime tests, let's migrate to use either an s3 bucket for test data or check them into the repo. the first is ideal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also create a second repo just for resources. I would actually prefer that because this would allow everyone to fully replicate the setup even it the s3 bucket goes away

@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 30, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 30, 2021
@Zha0q1 Zha0q1 merged commit 5637325 into apache:v1.x Feb 2, 2021
@Zha0q1
Copy link
Contributor

Zha0q1 commented Feb 2, 2021

Let's move the test images to a separate repo/s3 in the next pr. Merging this for now, thanks @josephevans

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 left review comments

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@josephevans @mxnet-bot @Zha0q1 @marcoabreu @waytrue17 @lanking520