Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.8.x] Backport fix for breaking change introduced in #17123 when batch_axis=0 #19282

Closed
wants to merge 11 commits into from

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Oct 2, 2020

Description

Backport #19267 to v1.8.x

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

szha and others added 11 commits September 19, 2020 21:50
* Fixed Install page history broken (apache#18182)

* fix install option block history broke

* when history goes back, avoid button default css blue outline

* use appropriate parameter name

* format scss change

* Update website version select drop down (apache#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Update website version select drop down (apache#18188)

* update version select drop down

* align caret

* revert scrollable content, add delayed hover effect

* bugfix

* fix new design doesn't work on mobile
# Conflicts:
#	docs/static_site/src/_includes/get_started/get_started.html

* Fix gluon link missing (apache#18243)

* fix gluon link missing

* empty commit to trigger checks

* empty commit to trigger checks

* fix when clicking version dropdown it jumps to top of the page (apache#18238)

* Website global search feature (apache#18288)

* init global search ui

* add hover effect to icon and refactor js

* add search bar ui styles

* fix search UI's effect on navbar height

* add fade in/out effect to search ui and navbar

* update search trigger to click and add x button for close

* add version select for search

* fix version typo

* update dropdown

* fix hitsperpage reset after change version

* fix nav trigger not show

* update search border css class name

* make dropdown style consistent

* global search mobile&tablet UI

* adjust mobile search result width

* extract global search related styles to a seperate scss

* restore formatting to existing code

* format & coding style

* fix caret height bug

* add mobile compatible UI

* add license header to js files and update dropdown width

* put docsearch css before main to overrides

* update search result panel height

* dynamically generate version dropdown

* use more accurate selector over search result

* use vh for height

* add comments  to scss

* move versions to Jekyll global variable

* remove redundant version key

* make global search default version the same as website version

Co-authored-by: Yang Shi <[email protected]>

* replace google CDN with JQuery's own CDN (apache#18369)

Co-authored-by: Yang Shi <[email protected]>

* Add Developer Guide Docs to MXNet Website (apache#18474)

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* init dev guide

* move dev guide above FAQ

* update format and images

* hoist git docs and fix styles

* use relative urls

* remove useless code block

* use consistent url and file name

* update heading

* add apache license header

* update doc - git clone recursive

* reviewing the dev guide - proof reading and text edits

Co-authored-by: Yang Shi <[email protected]>
Co-authored-by: Talia Chopra <[email protected]>

* fix contribute page anchor position shifted (apache#18571)

Co-authored-by: Yang Shi <[email protected]>

* Clipboard refactor (apache#18605)

* refactor clipboard

* make lang getter more extensible

* trigger ci

* User Feedback Widget (apache#18639)

* user feedback widget implementation

* add user feedback widget to python docs site

* update margin

* add apache license

* one more license

* turn off feedback widget on python site

* update copy

* format

* add event value field

* turn on widget on Python site
# Conflicts:
#	docs/static_site/src/_includes/head.html
#	docs/static_site/src/assets/main.scss

* Fix python micro-site table of content bugs (apache#18664)

* update footer style

* add compiled css of footer styles changes

* add same style for footer2

* more fix to the toc

* Fix all anchor shifts on website (apache#18674)

* use regex that is supported by all browsers (apache#18811)

* 1.7 compatible fix

* add jquery fix

* Consolidate installation instructions on website and add disclaimer for non-ASF ressources (apache#18487)

* Update website with disclaimer for non-ASF ressources

* Integrate Windows instructions to build_from_source.md

* Remove master version from selector

* Update Download links

* Update get_started/download.md per Release Download Page policy
# Conflicts:
#	contrib/clojure-package/README.md
#	docs/python_docs/python/tutorials/deploy/inference/image_classification_jetson.md
#	docs/static_site/src/_includes/get_started/get_started.html
#	docs/static_site/src/_includes/get_started/linux/clojure/gpu.md
#	docs/static_site/src/_includes/get_started/linux/java/gpu.md
#	docs/static_site/src/_includes/get_started/linux/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/perl/perl.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/docker.md
#	docs/static_site/src/_includes/get_started/linux/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/linux/r/gpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/cpu.md
#	docs/static_site/src/_includes/get_started/linux/scala/gpu.md
#	docs/static_site/src/_includes/get_started/macos
#	docs/static_site/src/_includes/get_started/macos/clojure/cpu.md
#	docs/static_site/src/_includes/get_started/macos/julia/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/perl/perl.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/macos/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/macos/python/gpu/pip_docker.md
#	docs/static_site/src/_includes/get_started/macos/r/cpu.md
#	docs/static_site/src/_includes/get_started/macos/scala/cpu.md
#	docs/static_site/src/_includes/get_started/windows
#	docs/static_site/src/_includes/get_started/windows/perl/perl.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/build-from-source.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/docker.md
#	docs/static_site/src/_includes/get_started/windows/python/cpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/python/gpu/pip.md
#	docs/static_site/src/_includes/get_started/windows/r/cpu.md
#	docs/static_site/src/_includes/get_started/windows/r/gpu.md
#	docs/static_site/src/pages/get_started/build_from_source.md
#	docs/static_site/src/pages/get_started/download.md
#	docs/static_site/src/pages/get_started/osx_setup.md
#	docs/static_site/src/pages/get_started/ubuntu_setup.md
#	docs/static_site/src/pages/get_started/windows_setup.md

* fix broken installation widget - remove empty entries (apache#18661)

* update static files

# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map

* update header dropdown default version

* fix failed pipeline

* cherry pick 1.7 content from master

* update version number in image classification tutorial

* minor version fix

* fix bullet point format bug

* Fixed python website double scroller and improve UX (apache#18845)

* make python site header scroll aware and avoid double scroller

* add compiled assets

* adjust python site second header height

* add new line

* set focus to main content on DOM load
# Conflicts:
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.css.map
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js
#	docs/python_docs/themes/mx-theme/mxtheme/static/sphinx_materialdesign_theme.js.map
#	docs/python_docs/themes/mx-theme/src/scss/_root.scss

* add jekyll base url to enable relative path

* fix python micro site header link path

* update python site css

Co-authored-by: Yang Shi <[email protected]>
Co-authored-by: Talia Chopra <[email protected]>
Co-authored-by: Leonard Lausen <[email protected]>
* updated version in base.h

* added missing files

Co-authored-by: Ubuntu <[email protected]>
* Fix ElementwiseSum for DNNL

* Fix sanity and replace push_back with emplace_back

* Change order of the data format conditions

* Add NOLINT to avoid readability error

* Add test for oneDNN ElemwiseSum

Co-authored-by: Bart Gawrych <[email protected]>

Co-authored-by: Bart Gawrych <[email protected]>
* fixing batch_norm and layer_norm for large tensors (apache#17805)

Co-authored-by: Rohit Kumar Srivastava <[email protected]>

* Fix nightly large_vector test caused by incorrect with_seed path (apache#18178)

* add back the missing environment function

Co-authored-by: Rohit Kumar Srivastava <[email protected]>
Co-authored-by: Rohit Kumar Srivastava <[email protected]>
* Assure NDArray.reshape does not change the array size

* Truncate wikitext-2 to match target array size on reshape

Co-authored-by: r3stl355 <[email protected]>
@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, edge, centos-cpu, unix-gpu, unix-cpu, website, centos-gpu, miscellaneous, clang, windows-cpu, windows-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@samskalicky samskalicky changed the title [BACKPORT #19267][BUGFIX] fixing breaking change introduced in #17123 when batch_axis=0 [v1.8.x] Backport fix for breaking change introduced in #17123 when batch_axis=0 Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants