-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x] fixing breaking change introduced in #17123 when batch_axis=0 #19267
Conversation
Hey @access2rohit , Thanks for submitting the PR
CI supported jobs: [clang, edge, centos-cpu, centos-gpu, miscellaneous, website, windows-cpu, unix-cpu, windows-gpu, unix-gpu, sanity] Note: |
I think we may need to add a test case. Also, we should better add a comment in the code base that links to the issue. The root cause is that |
9d3761f
to
7d59f08
Compare
@mxnet-bot run ci [all] |
Jenkins CI successfully triggered : [website, sanity, centos-gpu, centos-cpu, edge, windows-cpu, unix-cpu, clang, windows-gpu, miscellaneous, unix-gpu] |
@sxjscience can you review again ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
earlier
split_and_save
on batch_axis=0 would take in CSRNDArray and return CSRNDArray but now its not doing the same and returns NDArray. This causes change in external API behaviour. More details in #19268. Change was introduced in #17123Checklist
Essentials
Behaviour After Fix
output: