Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

refactor gluon.utils.split_data() following np.array_split() #17123

Merged
merged 6 commits into from
Jan 6, 2020

Conversation

zburning
Copy link
Contributor

Description

Fixes #17105

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@zburning zburning requested a review from szha as a code owner December 19, 2019 09:43
@sxjscience
Copy link
Member

@haojin2 haojin2 self-assigned this Dec 20, 2019
@haojin2 haojin2 added the Numpy label Dec 20, 2019
@haojin2 haojin2 removed their assignment Dec 20, 2019
@haojin2 haojin2 added the Gluon label Dec 20, 2019
@zburning
Copy link
Contributor Author

zburning commented Dec 20, 2019

@sxjscience
Copy link
Member

@zburning Sorry my meaning was to test the mx.np version. Has it been tested somewhere?

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 1612533 into apache:master Jan 6, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 1, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 1, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 1, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 2, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 2, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 2, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 3, 2020
access2rohit pushed a commit to access2rohit/incubator-mxnet that referenced this pull request Oct 3, 2020
samskalicky pushed a commit that referenced this pull request Oct 3, 2020
samskalicky pushed a commit that referenced this pull request Oct 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with gluon.utils.split_data()
4 participants