Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

License issues need to be fixed before 1.6 release #15542

Closed
11 tasks done
roywei opened this issue Jul 15, 2019 · 9 comments
Closed
11 tasks done

License issues need to be fixed before 1.6 release #15542

roywei opened this issue Jul 15, 2019 · 9 comments

Comments

@roywei
Copy link
Member

roywei commented Jul 15, 2019

I am creating this issue to be tracked and resolved before next release according to the discussion on @general during 1.5.0 release:
https://mail-archives.apache.org/mod_mbox/incubator-general/201907.mbox/%3CCAMbkE7T6wP6ph6qgDkmKfC6wZ0Cj7ajBbHyE-h-67%3DUKDCka0g%40mail.gmail.com%3E

  1. Mention original license for ONNX export module and FindJeMalloc, as we have modified the code and licensed under ASF, need to mention the original license as well

Our licenses: ONNX Export Module and FindJeMalloc.cmake,
ONNX Export original: https://github.com/NVIDIA/mxnet_to_onnx/blob/master/LICENSE
FindJeMalloc original: https://github.com/STEllAR-GROUP/hpx/blob/master/cmake/FindJemalloc.cmake

  1. Following licenses are missing, need to be added, they are all permissive licenses
  • /3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tools/FindPythonLibsNew.cmake
  • /src/operator/contrib/erfinv-inl.h
  • /3rdparty/nvidia_cub/test/mersenne.h
  • /3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/tools/FindEigen3.cmake
  • /3rdparty/onnx-tensorrt/third_party/onnx/tools/protoc-gen-mypy.py
  • /src/operator/special_functions-inl.h
  • /3rdparty/tvm/3rdparty/rang/LICENSE

Following are nonpermissive license issues tracked separately:

  1. Cub license issue tracked separately here; Cub license issue  #15569

  2. MKLDNN license issue tracked remove mkl blas lincense #15544

  3. Pybind license issue Pybind11 license issue from onnx tensorrt #15547

  4. Lastly, we have images in our source release, we need to identify and add their license or replace them.

  • ./contrib/clojure-package/examples/infer/objectdetector/images/marcel.jpg
  • ./contrib/clojure-package/test/test-images/Pug-Cookie.jpg
  • ./contrib/clojure-package/test/test-images/kitten.jpg
  • ./julia/examples/imagenet/ijulia-pretrained-predict/cat.png

more details on general list

@roywei
Copy link
Member Author

roywei commented Jul 15, 2019

@Roshrini any idea why we have a different ONNX export module license than the one on NVIDIA? maybe they changed the license after we used it?


update, since we modified the original code, so it should be licensed under ASF, we just need to mention the original license as well.

@vrakesh
Copy link
Contributor

vrakesh commented Jul 15, 2019

@mxnet-label-bot add [ONNX]

@roywei
Copy link
Member Author

roywei commented Jul 15, 2019

@mxnet-label-bot add [Licenses]

@roywei roywei changed the title Mention original license for ONNX export module and FindJeMalloc License issues need to be fixed before 1.6 release Jul 19, 2019
@pengzhao-intel
Copy link
Contributor

We will update MKL-DNN 1.0 in the next release and no MKLML is needed again.

@TaoLv
Copy link
Member

TaoLv commented Aug 8, 2019

@roywei do you happen to know any updates for these license issues?

@roywei
Copy link
Member Author

roywei commented Aug 9, 2019

@gigasquid @adc17 @iblis17 could you help replace the images mentioned in 6 in the issue? We would like to fix them for 1.5.1 release.
Thanks!

@iblislin
Copy link
Member

well, I'm not sure the source of ./julia/examples/imagenet/ijulia-pretrained-predict/cat.png.
@pluskid Can you recall that ?

@gigasquid
Copy link
Member

License issues have been fixed for the Clojure package and 1.5 branch - see #15828 for details

@roywei
Copy link
Member Author

roywei commented Jan 24, 2020

Closing as we have open issue tracking the remaining pybind and cub license. everything else is resolved.

@roywei roywei closed this as completed Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants