This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Clojure package remove source images #15828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roywei
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
kedarbellare
approved these changes
Aug 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Thank you @gigasquid for the contribution. Would you mind picking this to the v1.5.x branch? We hope the license issue can be addressed in the 1.5.x patch release. Thanks! |
gigasquid
added a commit
that referenced
this pull request
Aug 11, 2019
* remove test images * add script and .gitignore * add test helper to download images * remove unlicensed pic * add license header
@TaoLv - I meant to do a PR to the v1.5.x branch for the cherry-pick, but instead I pushed the commit to the branch directly https://github.com/apache/incubator-mxnet/commits/v1.5.x I think it's fine, but if you want to double check, that would be great. |
11 tasks
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* remove test images * add script and .gitignore * add test helper to download images * remove unlicensed pic * add license header
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The removes images from the clojure package to help resolve license issues from
#15542
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.