Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Clojure package remove source images #15828

Merged
merged 5 commits into from
Aug 11, 2019

Conversation

gigasquid
Copy link
Member

Description

The removes images from the clojure package to help resolve license issues from
#15542

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@gigasquid gigasquid requested a review from roywei August 9, 2019 20:15
Copy link
Member

@roywei roywei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Contributor

@kedarbellare kedarbellare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@roywei roywei merged commit 57927a9 into master Aug 11, 2019
@TaoLv
Copy link
Member

TaoLv commented Aug 11, 2019

Thank you @gigasquid for the contribution. Would you mind picking this to the v1.5.x branch? We hope the license issue can be addressed in the 1.5.x patch release. Thanks!

@gigasquid gigasquid deleted the clojure-package-remove-source-images branch August 11, 2019 12:18
gigasquid added a commit that referenced this pull request Aug 11, 2019
* remove test images

* add script and .gitignore

* add test helper to download images

* remove unlicensed pic

* add license header
@gigasquid
Copy link
Member Author

@TaoLv - I meant to do a PR to the v1.5.x branch for the cherry-pick, but instead I pushed the commit to the branch directly https://github.com/apache/incubator-mxnet/commits/v1.5.x

I think it's fine, but if you want to double check, that would be great.

anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* remove test images

* add script and .gitignore

* add test helper to download images

* remove unlicensed pic

* add license header
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants