Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

remove mkl blas lincense #15544

Closed
roywei opened this issue Jul 15, 2019 · 10 comments
Closed

remove mkl blas lincense #15544

roywei opened this issue Jul 15, 2019 · 10 comments
Labels

Comments

@roywei
Copy link
Member

roywei commented Jul 15, 2019

According to @general discussion, we should remove MKL BLAS lincense if we are not shipping it with our source release.

https://mail-archives.apache.org/mod_mbox/incubator-general/201907.mbox/%3C29E387FB-238F-4FC2-A41D-E4AB99AF4911%40classsoftware.com%3E

Currently we added it in license file here: https://github.com/apache/incubator-mxnet/blob/master/LICENSE#L624

cc @pengzhao-intel

@mxnet-label-bot
Copy link
Contributor

Hey, this is the MXNet Label Bot.
Thank you for submitting the issue! I will try and suggest some labels so that the appropriate MXNet community members can help resolve it.
Here are my recommended labels: Build

@roywei
Copy link
Member Author

roywei commented Jul 16, 2019

@mxnet-label-bot add [Licenses]

@pengzhao-intel
Copy link
Contributor

pengzhao-intel commented Jul 16, 2019

Yes, I think it makes sense to remove MKL license because full MKL package is an option.

@roywei would you mind file a PR to remove it?

@pengzhao-intel
Copy link
Contributor

pengzhao-intel commented Jul 16, 2019

cc @TaoLv

@paulk-asert
Copy link
Contributor

paulk-asert commented Jul 16, 2019

It isn't to do with "full MKL package being an option" per se, although related. There is a file that is downloaded as part of the build process that has the "Intel® Simplified license". The file is downloaded under external and then copied into build/install. However, there is no source file in your source tarball that has such a license, hence it should not be part of the LICENSE file.

@paulk-asert
Copy link
Contributor

I should also note that while removing the section from the source LICENSE file fixes the source tarball, you still seem to have issues with other artefacts, e.g. mxnet-full_2.11-linux-x86_64-cpu-1.5.0-SNAPSHOT.jar (as an example) contains the affected .so files and so should mention that license within it's META_INF/LICENSE file which it does not (nor any of the other compatible licenses). Of course, then the issues which @jmclean mentioned wrt category-x apply to that artefact. The general strategy I have seen used in such cases is to have the respective .so files come in via an optional non-Apache artefact and be automatically added to library path as needed.

@samskalicky
Copy link
Contributor

Yes, I think it makes sense to remove MKL license because full MKL package is an option.

@roywei would you mind file a PR to remove it?

@roywei Did you remove this, or did we just modify the license appropriately? Can you summarize what is left to do to close this issue?

@roywei
Copy link
Member Author

roywei commented Oct 14, 2019

@samskalicky I think this can be closed when we integrate with mkldnn v1.0, which is still in a branch https://github.com/apache/incubator-mxnet/tree/mkldnn-v1.0

@samskalicky
Copy link
Contributor

Thanks, i'll follow up with the Intel folks

@TaoLv
Copy link
Member

TaoLv commented Nov 1, 2019

@roywei @samskalicky I think this has been fixed on master branch. I'm closing this issue. Feel free to reopen if any concern. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants