Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Pybind11 license issue from onnx tensorrt #15547

Closed
roywei opened this issue Jul 16, 2019 · 11 comments
Closed

Pybind11 license issue from onnx tensorrt #15547

roywei opened this issue Jul 16, 2019 · 11 comments

Comments

@roywei
Copy link
Member

roywei commented Jul 16, 2019

follow up on 1.5.0 release vote discussion on @general:https://mail-archives.apache.org/mod_mbox/incubator-general/201907.mbox/%3Cpony-fd9da504b63c1736e52a84ae954da2a315f2f28a-abe0ddab200aaebfe96f1266ab8118e4927ddc8b%40general.incubator.apache.org%3E

We need to evaluate whether we can include the following license:
3rdparty/onnx-tensorrt/third_party/onnx/third_party/pybind11/LICENSE

I have created a LEGAL JIRA issue here: https://issues.apache.org/jira/browse/LEGAL-468

@vrakesh
Copy link
Contributor

vrakesh commented Jul 16, 2019

@mxnet-label-bot add [ONNX]

@vrakesh
Copy link
Contributor

vrakesh commented Jul 16, 2019

@mxnet-label-bot add [Licenses]

@roywei roywei changed the title onnx tensorrt Pybind11 license issue from onnx tensorrt Jul 19, 2019
@roywei
Copy link
Member Author

roywei commented Aug 9, 2019

https://issues.apache.org/jira/browse/LEGAL-468 is closed as the latest Pybind11 license is permissive. But we need to ask onnx-tensorrt and onnx to update them.

@KellenSunderland @Caenorst could you guys help?

Thanks

@ptrendx
Copy link
Member

ptrendx commented Jan 16, 2020

The latest ONNX-TensorRT (v7.0) contains the onnx commit that has the right LICENSE in pyBind. However, switching to it would first of all require some changes to the way it is called and second of all require matching TensorRT 7, so I would much prefer to do this in 1.7 release and not as the last thing in 1.6.

@KellenSunderland
Copy link
Contributor

I'd also propose we do this in the 1.7 release.

@leezu
Copy link
Contributor

leezu commented Jan 21, 2020

I think approval needs to be requested at https://issues.apache.org/jira/browse/LEGAL-468 if the borderline-compliant license should be used in the release?

@leezu
Copy link
Contributor

leezu commented Jan 24, 2020

Apache legal didn't have concerns to continue release as is currently. See above linked thread.

@ciyongch
Copy link
Contributor

Hi @ptrendx @KellenSunderland is there any update for this license issue? Do you think we can include the fix in the coming v1.7.0 release? Thanks!

@ciyongch
Copy link
Contributor

Hi @leezu @roywei , may I have your suggestions for this issue, since it's not a concern for the previous version, so supposes it's also fine to the upcoming 1.7.0 release. Am I right?
Thanks!

Apache legal didn't have concerns to continue release as is currently. See above linked thread.

@ciyongch
Copy link
Contributor

Hi @ptrendx , I'm reaching you to check if ONNX-TensorRT (v7.0) is still targeting in 1.7.0 release or not? The license concern would be still there with current code base, right? Thanks!

@szha
Copy link
Member

szha commented Oct 21, 2020

This has been resolved in #18574

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants