Skip to content

Conversation

@harrisric
Copy link
Contributor

@harrisric harrisric commented Jul 2, 2025

Fixes NPE when a classifier part is specified in the matching criteria but an artifact classifier is null rather than empty.
Fixes #903

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski slawekjaranowski added the bug Something isn't working label Jul 6, 2025
@slawekjaranowski slawekjaranowski merged commit b25c800 into apache:master Jul 6, 2025
26 checks passed
@github-actions github-actions bot added this to the 3.6.1 milestone Jul 6, 2025
dongjoon-hyun added a commit to apache/orc that referenced this pull request Aug 28, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `maven-enforcer-plugin` to 3.6.1.

### Why are the changes needed?

To use the latest improvement and bug fixed version:
- https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.1
  - apache/maven-enforcer#904
  - apache/maven-enforcer#905
  - apache/maven-enforcer#910

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2335

Closes #2366 from dongjoon-hyun/ORC-1978.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun added a commit to apache/orc that referenced this pull request Aug 28, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `maven-enforcer-plugin` to 3.6.1.

### Why are the changes needed?

To use the latest improvement and bug fixed version:
- https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.1
  - apache/maven-enforcer#904
  - apache/maven-enforcer#905
  - apache/maven-enforcer#910

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2335

Closes #2366 from dongjoon-hyun/ORC-1978.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 9d9ba5c)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.6.0 NPE, regression from 3.5.0, when working with classifier

2 participants