Skip to content

Fix NPE when a classifier part is specified in bannedDependencies #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025
Merged

Fix NPE when a classifier part is specified in bannedDependencies #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/utils/ArtifactMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ private boolean match(
}

private boolean matches(int index, String input) {
// TODO: Check if this can be done better or prevented earlier.
if (input == null) {
input = "";
}
// return matches(parts[index], input);
if (partsRegex[index] == null) {
String regex = parts[index]
Expand All @@ -157,10 +161,6 @@ private boolean matches(int index, String input) {
.replace("(", "\\(")
.replace(")", "\\)");

// TODO: Check if this can be done better or prevented earlier.
if (input == null) {
input = "";
}
partsRegex[index] = java.util.regex.Pattern.compile(regex);
}
return partsRegex[index].matcher(input).matches();
Expand Down
13 changes: 13 additions & 0 deletions ...ules/src/test/java/org/apache/maven/enforcer/rules/dependency/BannedDependenciesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,19 @@ class BannedDependenciesTest {
@InjectMocks
private BannedDependencies rule;

@Test
void excludesDoNotUseTransitiveDependenciesNullSafe() throws Exception {
when(session.getCurrentProject()).thenReturn(project);
when(project.getDependencyArtifacts()).thenReturn(ARTIFACT_STUB_FACTORY.getTypedArtifacts());

rule.setSearchTransitive(false);
rule.setExcludes(Collections.singletonList("g:b:*:*:compile:*"));

assertThatCode(rule::execute)
.isInstanceOf(EnforcerRuleException.class)
.hasMessageContaining("g:b:jar:1.0 <--- banned via the exclude/include list");
}

@Test
void excludesDoNotUseTransitiveDependencies() throws Exception {
when(session.getCurrentProject()).thenReturn(project);
Expand Down