Improve performance of transitive dependency checks #904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of artifacts already validated during transitive dependency enforcement, so that we don't check the same ones multiple times.
In an example that I have we see the validation of ~19,000 artifacts where only ~1,300 are distinct.
This change keeps track of already checked artifacts and skips the validation.
I had tried to skip all the children of an already validated artifact but this did not achieve exactly the same result (some of the distinct artifacts no longer appeared in the validated set) and didn't actually seem to improve the performance much above the simple approach.
As
Artifact(and specificallyorg.apache.maven.artifact.DefaultArtifact) doesn't includescopein itsequalsmethod I couldn't simply track aSet<Artifact>and created a class local toArtifactMatcherfor the purpose instead.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.