Skip to content

Conversation

@cfmcgrady
Copy link
Contributor

Why are the changes needed?

Enable Hudi related unit tests

How was this patch tested?

Pass CI.

@pan3793
Copy link
Member

pan3793 commented Sep 14, 2022

-1 for this change.

The Hudi bundle jar is not hygienic, it collects lots of 3rd part jars w/o proper relocation which may cause potential class conflict. e.g. prometheus, curator, http client, parquet, rocksdb

@pan3793
Copy link
Member

pan3793 commented Sep 14, 2022

How about separating the Hudi IT into an independent module? Then the classpath of server and spark engine modules will not be affected by Hudi bundle jar

@codecov-commenter
Copy link

Codecov Report

Merging #3486 (5272727) into master (5dd245d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3486      +/-   ##
============================================
- Coverage     51.35%   51.29%   -0.06%     
  Complexity       13       13              
============================================
  Files           481      481              
  Lines         26734    26734              
  Branches       3750     3750              
============================================
- Hits          13729    13714      -15     
- Misses        11662    11671       +9     
- Partials       1343     1349       +6     
Impacted Files Coverage Δ
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) ⬇️
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 75.00% <0.00%> (-4.55%) ⬇️
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 78.00% <0.00%> (-4.00%) ⬇️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 76.59% <0.00%> (-2.13%) ⬇️
...ain/scala/org/apache/kyuubi/engine/EngineRef.scala 72.26% <0.00%> (-0.85%) ⬇️
...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala 89.27% <0.00%> (-0.70%) ⬇️
...a/org/apache/kyuubi/service/TFrontendService.scala 91.17% <0.00%> (-0.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants