Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Feb 7, 2023

Why are the changes needed?

Close #3528, address #3486 (comment)

Blocked by apache/hudi#6240 (comment)

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793 pan3793 changed the title Move Spark Hudi test to dedicated module [KYUUBI #3528] Move Spark Hudi test to dedicated module Feb 7, 2023
@pan3793 pan3793 changed the title [KYUUBI #3528] Move Spark Hudi test to dedicated module [KYUUBI #3528] Separating the Hudi IT into an independent module Feb 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Merging #4260 (f5e6067) into master (6bd0016) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4260      +/-   ##
============================================
- Coverage     53.66%   53.64%   -0.03%     
  Complexity       13       13              
============================================
  Files           562      562              
  Lines         30834    30834              
  Branches       4157     4157              
============================================
- Hits          16547    16540       -7     
- Misses        12732    12741       +9     
+ Partials       1555     1553       -2     
Impacted Files Coverage Δ
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 13.84% <0.00%> (-6.16%) ⬇️
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 77.77% <0.00%> (-4.05%) ⬇️
...ache/kyuubi/operation/KyuubiOperationManager.scala 80.00% <0.00%> (-2.67%) ⬇️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 76.59% <0.00%> (-2.13%) ⬇️
...apache/kyuubi/engine/JpsApplicationOperation.scala 77.41% <0.00%> (ø)
...rc/main/scala/org/apache/spark/ui/EnginePage.scala 79.43% <0.00%> (+0.28%) ⬆️
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 60.60% <0.00%> (+1.51%) ⬆️
...uubi/engine/spark/events/SparkOperationEvent.scala 94.44% <0.00%> (+5.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cxzl25 cxzl25 mentioned this pull request Mar 22, 2023
3 tasks
@pan3793 pan3793 closed this Apr 23, 2023
@pan3793 pan3793 deleted the hudi-it branch October 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement] Separating the Hudi IT into an independent module

2 participants