-
Notifications
You must be signed in to change notification settings - Fork 972
[COMMUNITY] Update maturity model #3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3743 +/- ##
=========================================
Coverage ? 52.64%
Complexity ? 13
=========================================
Files ? 494
Lines ? 27788
Branches ? 3835
=========================================
Hits ? 14630
Misses ? 11768
Partials ? 1390 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I second to comments from our mentor, can you elaborate a bit more what&why can we update the model, especially add some solid evidence, not only says that |
MATURITY.md
Outdated
| | CS20 | Decisions require a consensus among PMC members and are documented on the project's main communications channel. The PMC takes community opinions into account, but the PMC has the final word. | :white_check_mark: The project has been making important decisions on the mailing lists. | | ||
| | CS30 | The project uses documented voting rules to build consensus when discussion is not sufficient. | :white_check_mark: The project uses the standard ASF voting rules. | | ||
| | CS40 | In Apache projects, vetoes are only valid for code commits. The person exercising the veto must justify it with a technical explanation, as per the Apache voting rules defined in CS30. | :white_check_mark: The project has not used a veto at any point during incubation. | | ||
| | CS50 | All "important" discussions happen asynchronously in written form on the project's main communications channel. Offline, face-to-face or private discussions that affect the project are also documented on that channel. | :white_check_mark: The project has been making important decisions on the project mailing lists. Minor decisions may occasionally happen during code reviews, which are also asynchronous and in written form. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example:
Major features discussion:
Deprecation discussion:
| | IN20 | Contributors act as themselves, not as representatives of a corporation or organization. | :white_check_mark: The contributors act on their own initiative without representing a corporation or organization. | | ||
| | ID | Description | Status | | ||
| |------|------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | IN10 | The project is independent from any corporate or organizational influence. | :white_check_mark: The project team gathers people from different companies (AsiaInfo, bilibili, China Mobile, eBay, iQIYI, NetEase, T3, Zhihu ...). No company or organization has significantly more influence than any other. We can note a growth of the contributions coming from different contributors. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 12 PPMC members come from different companies, including AWS, eBay, Huawei, Sensors Data, NetEase, China Mobile, Ctrip, and T3
https://whimsy.apache.org/roster/ppmc/kyuubi
And the number of contributors is growing.
https://github.com/apache/incubator-kyuubi/graphs/contributors
MATURITY.md
Outdated
| | CS10 | The project maintains a public list of its contributors who have decision power. The project's PMC (Project Management Committee) consists of those contributors. | :white_check_mark: Committers and PPMC members are listed on the website’s community page, see [newcommitter](https://kyuubi.apache.org/become_committer.html) | | ||
| | CS20 | Decisions require a consensus among PMC members and are documented on the project's main communications channel. The PMC takes community opinions into account, but the PMC has the final word. | :white_check_mark: The project has been making important decisions on the mailing lists. | | ||
| | CS30 | The project uses documented voting rules to build consensus when discussion is not sufficient. | :white_check_mark: The project uses the standard ASF voting rules. | | ||
| | CS40 | In Apache projects, vetoes are only valid for code commits. The person exercising the veto must justify it with a technical explanation, as per the Apache voting rules defined in CS30. | :white_check_mark: The veto is used for code commits only, and each veto with a clear technical explanation. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For instance: #3486
|
@yaooqinn @WillemJiang I supplied examples to explain why I think the project reached such a standard. |
MATURITY.md
Outdated
| | CS50 | All "important" discussions happen asynchronously in written form on the project's main communications channel. Offline, face-to-face or private discussions that affect the project are also documented on that channel. | :white_large_square: The project has been making important decisions on the project mailing lists. Minor decisions may occasionally happen during code reviews, which are also asynchronous and in written form. | | ||
| | ID | Description | Status | | ||
| |------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | CS10 | The project maintains a public list of its contributors who have decision power. The project's PMC (Project Management Committee) consists of those contributors. | :white_check_mark: Committers and PPMC members are listed on the website’s community page, see [newcommitter](https://kyuubi.apache.org/become_committer.html) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we are here, add one more link [new_ppmc] https://kyuubi.apache.org/become_ppmc_member.html
MATURITY.md
Outdated
| | CS10 | The project maintains a public list of its contributors who have decision power. The project's PMC (Project Management Committee) consists of those contributors. | :white_check_mark: Committers and PPMC members are listed on the website’s community page, see [newcommitter](https://kyuubi.apache.org/become_committer.html), [newppmc](https://kyuubi.apache.org/become_pmc_member.html) | | ||
| | CS20 | Decisions require a consensus among PMC members and are documented on the project's main communications channel. The PMC takes community opinions into account, but the PMC has the final word. | :white_check_mark: The project has been making important decisions on the mailing lists. | | ||
| | CS30 | The project uses documented voting rules to build consensus when discussion is not sufficient. | :white_check_mark: The project uses the standard ASF voting rules. | | ||
| | CS40 | In Apache projects, vetoes are only valid for code commits. The person exercising the veto must justify it with a technical explanation, as per the Apache voting rules defined in CS30. | :white_check_mark: The veto is used for code commits only, and each veto with a clear technical explanation. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this sentence from passive voice to active.
We've used vetoes with clear technical explanations for code commits only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated
yaooqinn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only one typo
|
Thanks all for your review and approval, the success of Kyuubi is inseparable from all of you! Merging to master. |
Why are the changes needed?
This PR proposes to update the Kyuubi project maturity model to reflect the current project status.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request