Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Nov 1, 2022

Why are the changes needed?

This PR proposes to update the Kyuubi project maturity model to reflect the current project status.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Nov 1, 2022
@pan3793 pan3793 marked this pull request as ready for review November 1, 2022 14:37
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@bd35784). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3743   +/-   ##
=========================================
  Coverage          ?   52.64%           
  Complexity        ?       13           
=========================================
  Files             ?      494           
  Lines             ?    27788           
  Branches          ?     3835           
=========================================
  Hits              ?    14630           
  Misses            ?    11768           
  Partials          ?     1390           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yaooqinn
Copy link
Member

yaooqinn commented Nov 2, 2022

I second to comments from our mentor, can you elaborate a bit more what&why can we update the model, especially add some solid evidence, not only says that update .... reflect the current project status. which is clear to everyone

MATURITY.md Outdated
| CS20 | Decisions require a consensus among PMC members and are documented on the project's main communications channel. The PMC takes community opinions into account, but the PMC has the final word. | :white_check_mark: The project has been making important decisions on the mailing lists. |
| CS30 | The project uses documented voting rules to build consensus when discussion is not sufficient. | :white_check_mark: The project uses the standard ASF voting rules. |
| CS40 | In Apache projects, vetoes are only valid for code commits. The person exercising the veto must justify it with a technical explanation, as per the Apache voting rules defined in CS30. | :white_check_mark: The project has not used a veto at any point during incubation. |
| CS50 | All "important" discussions happen asynchronously in written form on the project's main communications channel. Offline, face-to-face or private discussions that affect the project are also documented on that channel. | :white_check_mark: The project has been making important decisions on the project mailing lists. Minor decisions may occasionally happen during code reviews, which are also asynchronous and in written form. |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| IN20 | Contributors act as themselves, not as representatives of a corporation or organization. | :white_check_mark: The contributors act on their own initiative without representing a corporation or organization. |
| ID | Description | Status |
|------|------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| IN10 | The project is independent from any corporate or organizational influence. | :white_check_mark: The project team gathers people from different companies (AsiaInfo, bilibili, China Mobile, eBay, iQIYI, NetEase, T3, Zhihu ...). No company or organization has significantly more influence than any other. We can note a growth of the contributions coming from different contributors. |
Copy link
Member Author

@pan3793 pan3793 Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 12 PPMC members come from different companies, including AWS, eBay, Huawei, Sensors Data, NetEase, China Mobile, Ctrip, and T3
https://whimsy.apache.org/roster/ppmc/kyuubi

And the number of contributors is growing.
https://github.com/apache/incubator-kyuubi/graphs/contributors

MATURITY.md Outdated
| CS10 | The project maintains a public list of its contributors who have decision power. The project's PMC (Project Management Committee) consists of those contributors. | :white_check_mark: Committers and PPMC members are listed on the website’s community page, see [newcommitter](https://kyuubi.apache.org/become_committer.html) |
| CS20 | Decisions require a consensus among PMC members and are documented on the project's main communications channel. The PMC takes community opinions into account, but the PMC has the final word. | :white_check_mark: The project has been making important decisions on the mailing lists. |
| CS30 | The project uses documented voting rules to build consensus when discussion is not sufficient. | :white_check_mark: The project uses the standard ASF voting rules. |
| CS40 | In Apache projects, vetoes are only valid for code commits. The person exercising the veto must justify it with a technical explanation, as per the Apache voting rules defined in CS30. | :white_check_mark: The veto is used for code commits only, and each veto with a clear technical explanation. |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For instance: #3486

@pan3793
Copy link
Member Author

pan3793 commented Nov 2, 2022

@yaooqinn @WillemJiang I supplied examples to explain why I think the project reached such a standard.

MATURITY.md Outdated
| CS50 | All "important" discussions happen asynchronously in written form on the project's main communications channel. Offline, face-to-face or private discussions that affect the project are also documented on that channel. | :white_large_square: The project has been making important decisions on the project mailing lists. Minor decisions may occasionally happen during code reviews, which are also asynchronous and in written form. |
| ID | Description | Status |
|------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| CS10 | The project maintains a public list of its contributors who have decision power. The project's PMC (Project Management Committee) consists of those contributors. | :white_check_mark: Committers and PPMC members are listed on the website’s community page, see [newcommitter](https://kyuubi.apache.org/become_committer.html) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we are here, add one more link [new_ppmc] https://kyuubi.apache.org/become_ppmc_member.html

MATURITY.md Outdated
| CS10 | The project maintains a public list of its contributors who have decision power. The project's PMC (Project Management Committee) consists of those contributors. | :white_check_mark: Committers and PPMC members are listed on the website’s community page, see [newcommitter](https://kyuubi.apache.org/become_committer.html), [newppmc](https://kyuubi.apache.org/become_pmc_member.html) |
| CS20 | Decisions require a consensus among PMC members and are documented on the project's main communications channel. The PMC takes community opinions into account, but the PMC has the final word. | :white_check_mark: The project has been making important decisions on the mailing lists. |
| CS30 | The project uses documented voting rules to build consensus when discussion is not sufficient. | :white_check_mark: The project uses the standard ASF voting rules. |
| CS40 | In Apache projects, vetoes are only valid for code commits. The person exercising the veto must justify it with a technical explanation, as per the Apache voting rules defined in CS30. | :white_check_mark: The veto is used for code commits only, and each veto with a clear technical explanation. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this sentence from passive voice to active.

We've used vetoes with clear technical explanations for code commits only.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

Copy link
Member

@yaooqinn yaooqinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one typo

@pan3793 pan3793 self-assigned this Nov 5, 2022
@pan3793 pan3793 added this to the v1.7.0 milestone Nov 5, 2022
@pan3793
Copy link
Member Author

pan3793 commented Nov 6, 2022

Thanks all for your review and approval, the success of Kyuubi is inseparable from all of you! Merging to master.

@pan3793 pan3793 added the kind:infra license, community building, project builds, asf infra related, etc. label Nov 6, 2022
@pan3793 pan3793 closed this in 77cfa16 Nov 6, 2022
@pan3793 pan3793 deleted the maturity branch November 13, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation Documentation is a feature! kind:infra license, community building, project builds, asf infra related, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.