KAFKA-9589: Fixed bug in V2 log validator tests#8533
Merged
Conversation
leonardge
changed the title
leonardge
changed the title
leonardge
changed the title
Member
|
ok to test |
Contributor
Author
|
Why is the CI failing? |
Contributor
|
JDK 8 failed with May be an intermittent issue. retest this please |
Contributor
Author
|
Hi @ijuma it will be great if you can re start the tests. Thanks! |
Member
|
retest this please |
1 similar comment
Member
|
retest this please |
Contributor
Author
|
The tests that are failing doesn't seem to be relevant to my change which are the following:
|
Contributor
Author
|
QueryableStateIntegrationTest.shouldAllowConcurrentAccesses JIRA: MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete JIRA: @ijuma It will be great if you can provide me some pointers on what should I do in this case? Thanks for your help! |
Contributor
Author
|
Hi @ijuma @hachikuji , it will be nice if you can take a look at this PR. |
Member
|
retest this please |
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 7, 2020
* 'trunk' of github.com:apache/kafka: (87 commits) KAFKA-9865: Expose output topic names from TopologyTestDriver (apache#8483) MINOR - Increase the number of Trogdor Histogram buckets to 10000 (apache#8627) KAFKA-9768: Fix handling of rest.advertised.listener config (apache#8360) KAFKA-9419: Fix possible integer overflow in CircularIterator (apache#7950) MINOR: Only add 'Data' suffix for generated request/response/header types (apache#8625) KAFKA-9947; Ensure proper shutdown of services in `TransactionsBounceTest` (apache#8602) KAFKA-6342; Remove unused workaround for JSON parsing of non-escaped strings (apache#8591) MINOR: Pass `-release 8` to scalac and upgrade to Gradle 6.4 (apache#8538) KAFKA-9946; Partition deletion event should only be sent if deletion was requested in the StopReplica request (apache#8609) MINOR: Improve TopologyTestDriver JavaDocs (apache#8619) MINOR: MockAdminClient should return InvalidReplicationFactorException if brokers.size < replicationFactor KAFKA-9748: Add Streams eos-beta integration test (apache#8496) KAFKA-9731: Disable immediate fetch response for hw propagation if replica selector is not defined (apache#8607) HOTFIX: set correct numIterations in shouldAllowConcurrentAccesses MINOR: Clean up some test dependencies on ConfigCommand and TopicCommand (apache#8527) KAFKA-9918; SslEngineFactory is NOT closed when channel is closing (apache#8551) KAFKA-9798: Send one round synchronously before starting the async producer (apache#8565) MINOR: Annotate KafkaAdminClientTest.testAlterClientQuotas() with @test KAFKA-9589: Enable testLogAppendTimeNonCompressedV2 and fix bug in helper method (apache#8533) MINOR: Use min/max function when possible (apache#8577) ... # Conflicts: # core/src/main/scala/kafka/log/Log.scala # gradle/dependencies.gradle # gradle/wrapper/gradle-wrapper.properties # gradlew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we fixed a test that is written but not ran.
JIRA here: https://issues.apache.org/jira/browse/KAFKA-9589
Committer Checklist (excluded from commit message)