KAFKA-2650: Change ConfigCommand --deleted-config option to align wit…#308
Closed
granthenke wants to merge 2 commits into
Closed
KAFKA-2650: Change ConfigCommand --deleted-config option to align wit…#308granthenke wants to merge 2 commits into
granthenke wants to merge 2 commits into
Conversation
Contributor
|
LGTM. |
Contributor
|
@lindong28 @auradkar FYI - I'm committing this, since it makes transition to the new tool easier. Note that since you are running from trunk, you may need to modify some scripts / tools... |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
… in reflective created object. (apache#308) * Behavior change: PARTITION_METRIC_SAMPLE_STORE_TOPIC_CONFIG and BROKER_METRIC_SAMPLE_STORE_TOPIC_CONFIG are now required configs -- i.e. no default value is provided, exception will be thrown if they are missing.
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
* feat(inkless): add commit wait time Inkless commit waits for uploads to happen. This period is not measure yet; and may grow significantly when too many requests are scheduled concurrently. Measuring this should help to improve pipelining and tuning. * test(inkless): remove unneeded throws
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
* feat(inkless): add commit wait time Inkless commit waits for uploads to happen. This period is not measure yet; and may grow significantly when too many requests are scheduled concurrently. Measuring this should help to improve pipelining and tuning. * test(inkless): remove unneeded throws
traceyyoshima
pushed a commit
to traceyyoshima/kafka
that referenced
this pull request
May 23, 2026
Re-applied after PRs apache#305-apache#308 merged on language-engine main: - apache#305: ternary + lambda close-brace partial-cascade - apache#306: chain-inside-ternary-branch - apache#307: inline-call close-paren cascade - apache#308: ternary normalize to continuation_indent under EXPLICIT Stats: 3,113 files written / 5,779 evaluated / 0 errors / 0 non-idempotent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h TopicCommand