KAFKA-2484: Add schema projection utilities#307
Closed
Ishiihara wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Can we fill in a regular javadoc description. It'll probably be similar to the one on the class.
Contributor
Author
|
@ewencp Addressed the review comments and updated the PR. Please take a look when you have time. |
Contributor
There was a problem hiding this comment.
If the record is null, this isn't doing any schema compatibility checks besides the check for optional/required check at the top of this method. This is causing the logical type test to fail.
Contributor
Author
|
@ewencp Update PR according to your review comments. |
Contributor
|
Looks good. @gwenshap care to review & commit? |
Contributor
|
Looks great! Thanks @Ishiihara and @ewencp |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
…tricSampleAggregator (apache#307)
hachikuji
added a commit
to hachikuji/kafka
that referenced
this pull request
May 6, 2020
This patch makes the following improvements: 1. Replace the usage of `requestId` with `correlationId`, which is already widely used in Kafka. 2. Make `MockLog` aware of record batching to make its behavior more consistent with the `Log` implementation and to 3. Add test coverage to `ConnectionCache`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds schema projection utilities to copycat.