Skip to content

KAFKA-2536: topics tool should allow users to alter topic configuration#305

Closed
granthenke wants to merge 1 commit into
apache:trunkfrom
granthenke:topic-configs
Closed

KAFKA-2536: topics tool should allow users to alter topic configuration#305
granthenke wants to merge 1 commit into
apache:trunkfrom
granthenke:topic-configs

Conversation

@granthenke

Copy link
Copy Markdown
Member

This is a minimal revert of some backward incompatible changes made in KAFKA-2205, with the addition of the deprecation logging message.

@gwenshap

Copy link
Copy Markdown
Contributor

I am not super happy about:

  1. Code duplication with ConfigCommand
  2. That the same option is called --delete-config here and --deleted-config in ConfigCommand.

However, since the point is to simply return code that was removed in order to remove it later... I'll commit as is.

Can you file 2 JIRAs:

  1. For ConfigCommand to check if the parameter can be renamed to --delete-config in order to reduce confusion? We didn't release yet, so hopefully it is not too late.
  2. For 0.9.1 to remove the deprecated configs

@granthenke

Copy link
Copy Markdown
Member Author

@gwenshap I have created those Jiras:

  • KAFKA-2650: Change ConfigCommand --deleted-config option to align with TopicCommand
  • KAFKA-2651: Remove deprecated config alteration from TopicCommand in 0.9.1.0

I also created pull request #308 for KAFKA-2650.

@gwenshap

Copy link
Copy Markdown
Contributor

Committed KAFKA-2650, and I think this will work ok as an interim state.
LGTM.

@asfgit asfgit closed this in 3626133 Oct 14, 2015
@granthenke
granthenke deleted the topic-configs branch November 17, 2015 17:06
efeg pushed a commit to efeg/kafka that referenced this pull request Jan 29, 2020
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 16, 2022
…ests (apache#305)

The original commit in 2.4-li branch is
- [LI-HOTFIX] Basic server-side support for multi-cluster integration tests (apache#217)

TICKET = LIKAFKA-41598
LI_DESCRIPTION = This extends the existing integration-test framework by adding a "sister tree" of test-harness classes modified for multi-cluster use. (For now, the client side still supports only cluster 0.)
EXIT_CRITERIA = N/A

Co-authored-by: Greg Roelofs <newt@pobox.com>
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 28, 2022
…ests (apache#305)

The original commit in 2.4-li branch is
- [LI-HOTFIX] Basic server-side support for multi-cluster integration tests (apache#217)

TICKET = LIKAFKA-41598
LI_DESCRIPTION = This extends the existing integration-test framework by adding a "sister tree" of test-harness classes modified for multi-cluster use. (For now, the client side still supports only cluster 0.)
EXIT_CRITERIA = N/A

Co-authored-by: Greg Roelofs <newt@pobox.com>
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jun 16, 2022
…ests (apache#305)

The original commit in 2.4-li branch is
- [LI-HOTFIX] Basic server-side support for multi-cluster integration tests (apache#217)

TICKET = LIKAFKA-41598
LI_DESCRIPTION = This extends the existing integration-test framework by adding a "sister tree" of test-harness classes modified for multi-cluster use. (For now, the client side still supports only cluster 0.)
EXIT_CRITERIA = N/A

Co-authored-by: Greg Roelofs <newt@pobox.com>
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
…ompose (apache#305)

Split demo and monitoring services off of the default docker compose file
allows running a more minimal Docker compose environment without demo
producers/consumer and/or monitoring services.
jeqo pushed a commit to aiven/kafka that referenced this pull request Jan 16, 2026
…ompose (apache#305)

Split demo and monitoring services off of the default docker compose file
allows running a more minimal Docker compose environment without demo
producers/consumer and/or monitoring services.
traceyyoshima pushed a commit to traceyyoshima/kafka that referenced this pull request May 23, 2026
Re-applied after PRs apache#305-apache#308 merged on language-engine main:
  - apache#305: ternary + lambda close-brace partial-cascade
  - apache#306: chain-inside-ternary-branch
  - apache#307: inline-call close-paren cascade
  - apache#308: ternary normalize to continuation_indent under EXPLICIT

Stats: 3,113 files written / 5,779 evaluated / 0 errors / 0 non-idempotent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants