API, Core: Don't persist useless file and position bounds #8360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
force-pushed
the
ignore-file-stats-position-deletes
branch
from
be8ca32 to
c7698f5
Compare
aokolnychyi
force-pushed
the
ignore-file-stats-position-deletes
branch
from
c7698f5 to
94cda10
Compare
aokolnychyi
force-pushed
the
ignore-file-stats-position-deletes
branch
from
94cda10 to
96dabf6
Compare
singhpk234
approved these changes
Aug 21, 2023
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM as well, considering lower and upper bounds are optional in spec.
rdblue
reviewed
Aug 21, 2023
| private Metrics metrics() { | ||
| Metrics metrics = appender.metrics(); | ||
| if (referencedDataFiles.size() > 1) { | ||
| return MetricsUtil.copyWithoutFieldBounds(metrics, SINGLE_REFERENCED_FILE_BOUNDS_ONLY); |
Contributor
There was a problem hiding this comment.
Looks like the idea is only to drop the bounds for _file and _pos? I guess that would mean that we keep data column ranges that might be used for filtering?
Contributor
Author
There was a problem hiding this comment.
I am not aware of any engines that persist deleted rows but I opted in for an incremental change in behavior to be safe.
rdblue
reviewed
Aug 21, 2023
| Assert.assertNull(deleteFile.lowerBounds()); | ||
| Assert.assertNull(deleteFile.upperBounds()); | ||
| } else { | ||
| Assert.assertEquals(2, deleteFile.lowerBounds().size()); |
Contributor
There was a problem hiding this comment.
Should this also assert that referencedDataFiles.size() == 1?
Contributor
Author
There was a problem hiding this comment.
I'll add a check.
rdblue
approved these changes
Aug 21, 2023
Contributor
|
Looks good to me. |
Contributor
Author
|
Thanks for reviewing, @RussellSpitzer @singhpk234 @rdblue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the metrics collection in position delete files to drop useless boundaries. As discussed earlier, loading and comparing lower and upper boundaries in
DeleteFileIndexis fairly expensive and should be done only if makes sense. Given the nature of generated data file paths, it only makes sense to persist the boundaries if a position delete file covers a single data file. Otherwise, it only harms the planning performance.