Core: Don't persist counts for paths and positions in position delete files #8590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
commented
Sep 19, 2023
| * @param excludedFieldIds field IDs for which the counts must be dropped | ||
| * @return a new metrics object without counts for given fields | ||
| */ | ||
| public static Metrics copyWithoutFieldCounts(Metrics metrics, Set<Integer> excludedFieldIds) { |
Contributor
Author
There was a problem hiding this comment.
I considered creating a builder for coping metrics but I am not sure it would be worth the extra complexity and it is not clear whether there would be future use cases benefiting from it. For now, I simply added another util method.
Fokko
reviewed
Sep 19, 2023
Contributor
Author
RussellSpitzer
approved these changes
Sep 20, 2023
Contributor
Author
|
Thanks, @Fokko @RussellSpitzer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops count metrics for the file and position columns in position delete files. This allows us to reduce the size of persisted delete metadata and to speed up distributed planning where the stats are serialized. Such stats are redundant as the spec does not permit null values in those columns and we have
recordCountif the number of records must be known.We still keep counts for the data columns if deleted rows are persisted. We also keep column sizes for the file and position columns.