API: Revert to using stephenc findbugs dependency for Nullable #6815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyanyy
approved these changes
Feb 13, 2023
Contributor
|
Thanks for the fix and the quick reviews! |
rdblue
reviewed
Feb 13, 2023
|
|
||
| import edu.umd.cs.findbugs.annotations.Nullable; | ||
| import java.util.List; | ||
| import javax.annotation.Nullable; |
Contributor
There was a problem hiding this comment.
Doesn't the stephenc library define this annotation? Or is it just the edu.umd one?
Contributor
Author
There was a problem hiding this comment.
It just defines the edu.umd one. https://github.com/stephenc/findbugs-annotations/blob/master/src/main/java/edu/umd/cs/findbugs/annotations/Nullable.java#L39 actually it seems like its deprecated and recommends using javax which as far as I can tell can only come from com.google.code.findbugs
Member
|
we have the below compile warning because of the findbugs dependency removal.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts to using stephenc findbugs dependency for Nullable based on @rdblue comment here: https://github.com/apache/iceberg/pull/6598/files#r1103888557
cc @danielcweeks since there is a differing view based off of #6598 (comment) . In the current PR, we're reverting back to using the stephenc dependency, because it appears the javax one from com.google.code.findbugs:jsr305 is banned. Let me know your thoughts on reverting this!
To add a third option: It seems like the stephenc findbugs dependency has Nullable marked as deprecated, and based off https://stackoverflow.com/questions/19030954/cant-find-nullable-inside-javax-annotation spotbugs is the newer reccomended library to get the javax.annotation but this still just has a dependency on com.google.code.findbugs:jsr305.
CC: @jackye1995 who is managing the release for 1.2.0.