Skip to content

API: Revert to using stephenc findbugs dependency for Nullable #6815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackye1995 merged 1 commit into from
Feb 13, 2023
Merged

API: Revert to using stephenc findbugs dependency for Nullable #6815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
*/
package org.apache.iceberg.view;

import edu.umd.cs.findbugs.annotations.Nullable;
import java.util.List;
import javax.annotation.Nullable;
Copy link
Contributor

@rdblue rdblue Feb 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the stephenc library define this annotation? Or is it just the edu.umd one?

Copy link
Contributor Author

@amogh-jahagirdar amogh-jahagirdar Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just defines the edu.umd one. https://github.com/stephenc/findbugs-annotations/blob/master/src/main/java/edu/umd/cs/findbugs/annotations/Nullable.java#L39 actually it seems like its deprecated and recommends using javax which as far as I can tell can only come from com.google.code.findbugs

import org.apache.iceberg.catalog.Namespace;
import org.immutables.value.Value;

Expand Down
1 change: 0 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ project(':iceberg-api') {
dependencies {
implementation project(path: ':iceberg-bundled-guava', configuration: 'shadow')
compileOnly "com.google.errorprone:error_prone_annotations"
compileOnly 'com.google.code.findbugs:jsr305'
annotationProcessor "org.immutables:value"
compileOnly "org.immutables:value"
testImplementation "org.apache.avro:avro"
Expand Down
1 change: 0 additions & 1 deletion versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ org.apache.orc:* = 1.8.2
org.apache.parquet:* = 1.12.3
org.apache.pig:pig = 0.14.0
com.fasterxml.jackson.*:* = 2.14.1
com.google.code.findbugs:jsr305 = 3.0.2
com.google.errorprone:error_prone_annotations = 2.3.3
com.google.guava:* = 31.1-jre
com.github.ben-manes.caffeine:caffeine = 2.9.3
Expand Down