API, Core: Use Google findbugs dependency but as compileonly #6976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
force-pushed
the
nullable-annotation
branch
from
f0d05cf to
46b68b0
Compare
Contributor
jackye1995
approved these changes
Mar 1, 2023
ajantha-bhat
approved these changes
Mar 1, 2023
Member
ajantha-bhat
left a comment
ajantha-bhat
left a comment
There was a problem hiding this comment.
LGTM.
Also verified that this complier warning is fixed with this change.
nastra
approved these changes
Mar 1, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this!
Contributor
|
Given the fact that this is blocking 1.2 release, and we already had consensus in the community sync, I will go ahead to merge this PR. Thanks for the review @nastra and @ajantha-bhat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6966
This undoes the change I did here: #6815 so that we don't have any compile warnings and don't rely on the deprecated findbugs dependency. This change also updates other areas in the code to use the google findbugs dependency. This is a follow up from the last community sync.
cc: @rdblue @nastra @jackye1995