Core: Make DeleteFilter's constructor parameters more specific #4381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Mind taking a look? @rdblue @danielcweeks @findepi |
findepi
reviewed
Mar 24, 2022
|
|
||
| private final long setFilterThreshold; | ||
| private final DataFile dataFile; | ||
| private final CharSequence filePath; |
Member
There was a problem hiding this comment.
CharSequence doesn't guarantee immutabilty. Let's make it a String.
alexjo2144
force-pushed
the
delete-filter-constructor
branch
from
a137c1e to
d448b45
Compare
hililiwei
pushed a commit
to hililiwei/iceberg
that referenced
this pull request
Jun 29, 2022
…ific (apache#4381) Reference:(cherry picked from commit 0f6398f)
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 18, 2022
Initial-neko
pushed a commit
to Initial-neko/iceberg
that referenced
this pull request
Jul 20, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 9, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 10, 2022
hililiwei
added a commit
to hililiwei/iceberg
that referenced
this pull request
Aug 11, 2022
aokolnychyi
pushed a commit
that referenced
this pull request
Aug 12, 2022
|
I want to filter eq delete rows loaded in delete set by lower-upper bounds in data file, so can I replace filePath to dataFile as parameter in the construction? |
Member
I guess you mean these changes trinodb/trino#13219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the constructor arguments for DeleteFilters to just the parts of the FileScanTask actually used. This came up as a part of the Trino work to support merge-on-read tables and reusing DeleteFilter there.