Skip to content

Flink: Port fix cache refreshing in DynamicIcebergSink #14765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pvary merged 1 commit into from
Dec 5, 2025
Merged

Flink: Port fix cache refreshing in DynamicIcebergSink #14765

pvary merged 1 commit into from
Dec 5, 2025
+108 −8

Conversation

@aiborodin
Copy link
Contributor

@aiborodin aiborodin commented Dec 5, 2025

Port #14406 to Flink v1.20 and v2.1.

@aiborodin
Backport fix cache refreshing in dynamic sink
ae66ede 
Backport the change to Flink v1.20,v2.1

Change-Id: I5387e848f30807fe6de77a05ff9b206f2c546c17
@github-actions github-actions bot added the flink label Dec 5, 2025
@aiborodin
Copy link
Contributor Author

aiborodin commented Dec 5, 2025

@pvary the backport applied cleanly with no merge conflicts.

@pvary pvary merged commit c4ba60d into apache:main Dec 5, 2025
20 checks passed
@pvary
Copy link
Contributor

pvary commented Dec 5, 2025

Merged to main.
Thanks for the backport @aiborodin!

@pvary
Copy link
Contributor

pvary commented Dec 5, 2025

Do you think it would make sense to have this in 1.10.1?

@aiborodin
Copy link
Contributor Author

aiborodin commented Dec 7, 2025

Thank you for the review @pvary!
Yes, let's include this in 1.10.1.

@pvary pvary added this to the Iceberg 1.10.1 milestone Dec 8, 2025
@huaxingao
Copy link
Contributor

huaxingao commented Dec 15, 2025

@aiborodin @pvary
I was cutting RC0 on 12/7 and didn't notice this PR and #14406 were merged and marked for 1.10.1 release. I didn't recheck when i cut RC1 yesterday and only found out today.

Do we need to include these fix in 1.10.x? If yes, we need to cherrypick the fix and recut the RC.

@aiborodin
Copy link
Contributor Author

aiborodin commented Dec 16, 2025

@huaxingao, yes please, we should include this in 1.10.x to be consistent across Flink versions. How could I help with this?

Could we please also wait for the #14810 to be finalised? It would be good to release this change in 1.10.1 as well, as mentioned in #14810 (comment). cc: @pvary

@pvary
Copy link
Contributor

pvary commented Dec 16, 2025

I agree that we need to have #14765 in 1.10.1, but I think #14810 is not a fix, but a new feature. I would not recommend that in a maintenance release.

@huaxingao
Copy link
Contributor

huaxingao commented Dec 16, 2025

I just added #14810 to 1.10.1 milestone

@huaxingao
Copy link
Contributor

huaxingao commented Dec 16, 2025

Just cleared .10.1 milestone from #14810

huaxingao pushed a commit to huaxingao/iceberg that referenced this pull request Dec 16, 2025
@aiborodin @huaxingao
Flink: Backport fix cache refreshing in dynamic sink (apache#14765)
f98bd49 
Backport  apache#14406

(cherry picked from commit c4ba60d)
huaxingao added a commit that referenced this pull request Dec 16, 2025
@huaxingao @aiborodin
[1.10.x] Cherry-pick Flink: fix cache refreshing in dynamic sink (144…
ccb8bc4 
…06, 14765) (#14862)

* Flink: Fix cache refreshing in dynamic sink (#14406)

(cherry picked from commit 8db3d21)

* Flink: Backport fix cache refreshing in dynamic sink (#14765)

Backport  #14406

(cherry picked from commit c4ba60d)

---------

Co-authored-by: aiborodin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvary pvary pvary approved these changes

Assignees

No one assigned

Labels

flink

Projects

None yet

Milestone

Iceberg 1.10.1

Development

Successfully merging this pull request may close these issues.

3 participants

@aiborodin @pvary @huaxingao