Fix cache refreshing in DynamicIcebergSink #14406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pvary Could you please take a look at this one as well? |
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
...k/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestTableMetadataCache.java
Outdated
Show resolved
Hide resolved
pvary
reviewed
Oct 23, 2025
...k/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestTableMetadataCache.java
Outdated
Show resolved
Hide resolved
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java
Show resolved
Hide resolved
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
aiborodin
force-pushed
the
fix-cache-refreshing
branch
from
f61d755 to
f84408c
Compare
aiborodin
force-pushed
the
fix-cache-refreshing
branch
from
f84408c to
9df6544
Compare
The table cache should only refresh after it exists longer than the configured refresh interval. Not the opposite. Change-Id: I04fa10b291c9f839911e242f25969698bcb4a386
aiborodin
force-pushed
the
fix-cache-refreshing
branch
from
9df6544 to
591049e
Compare
pvary
approved these changes
Dec 5, 2025
Contributor
|
Merged to main. |
pvary
pushed a commit
that referenced
this pull request
Dec 5, 2025
mxm
reviewed
Dec 5, 2025
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/TableMetadataCache.java
Show resolved
Hide resolved
Contributor
|
@aiborodin: Do we want to see this in 1.10.1? |
Contributor
|
+1 Let's port this to 1.10.1. |
Contributor
Author
|
Thank you for the review @pvary! |
aiborodin
added a commit
to aiborodin/iceberg
that referenced
this pull request
Dec 7, 2025
huaxingao
pushed a commit
to huaxingao/iceberg
that referenced
this pull request
Dec 16, 2025
(cherry picked from commit 8db3d21)
huaxingao
pushed a commit
to huaxingao/iceberg
that referenced
this pull request
Dec 16, 2025
Backport apache#14406 (cherry picked from commit c4ba60d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TableMetadataCacheinDynamicIcebergSinkshould only refresh an entry after it exists longer than a configured refresh interval. Not the opposite.