AWS: Support similar S3 Sync Client configurations for S3 Async Clients #13387
Conversation
SanjayMarreddi
force-pushed
the
update_s3_async_clients
branch
from
1f33145 to
3988bda
Compare
SanjayMarreddi
force-pushed
the
update_s3_async_clients
branch
2 times, most recently
from
9241bbf to
bfb4f63
Compare
…erator is enabled
… is either enabled/disabled
SanjayMarreddi
force-pushed
the
update_s3_async_clients
branch
3 times, most recently
from
f9b0fb4 to
7be4137
Compare
SanjayMarreddi
force-pushed
the
update_s3_async_clients
branch
from
7be4137 to
da17914
Compare
|
|
||
| private S3AsyncClientWrapper flakyStreamAsyncClient(AtomicInteger counter, IOException failure) { | ||
| S3AsyncClientWrapper flakyClient = spy(new S3AsyncClientWrapper(s3AsyncClient())); | ||
| doAnswer(invocation -> new FlakyInputStream(invocation.callRealMethod(), counter, failure)) |
There was a problem hiding this comment.
[from testing] I'm not sure if this wrapper is 100% right. I am seeing cast exceptions will look in to this.
There was a problem hiding this comment.
Hi @stubz151 . I fixed the stubs with async client related changes. Now all tests with Async client are working as expected.
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
not stale |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
not stale |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
not stale |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
not stale |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
4 participants
Description
This PR is a follow-up to the existing PRs #13347, #13348, #13361 in the series addressing feature gaps in the stream powered by analytics-accelerator-s3. It's part of our ongoing effort towards default-on integration.
This PR specifically adds support for S3 Async Clients to have similar configurations like S3 Sync Clients. Since the CRT clients have some feature gaps, we have raised an issue here and disabled CRT client. Java Async Client ( Netty ) will be the default Async client used now.
Note that there is one feature gap between Apache (sync) and Netty (async) clients: the
APACHE_EXPECT_CONTINUE_ENABLEDproperty is not supported by Netty. All other configuration options have equivalent implementations.Testing
s3.analytics-accelerator.enabledis set to true, previously skipped integration teststestCrossRegionAccessEnabled,testNewInputStreamWithCrossRegionAccessPointwork now.