-
Notifications
You must be signed in to change notification settings - Fork 2.9k
AWS: Support metrics tracking when using Analytics Accelerator stream #13348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS: Support metrics tracking when using Analytics Accelerator stream #13348
Conversation
aws/src/integration/java/org/apache/iceberg/aws/s3/S3TestUtil.java
Outdated
Show resolved
Hide resolved
fuatbasik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot @SanjayMarreddi . I put some comments, mostly nitpicks.
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3MultipartUpload.java
Outdated
Show resolved
Hide resolved
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
Show resolved
Hide resolved
aws/src/integration/java/org/apache/iceberg/aws/s3/TestFlakyS3InputStream.java
Outdated
Show resolved
Hide resolved
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java
Show resolved
Hide resolved
b3cfc37 to
cb0c707
Compare
cb0c707 to
383b38b
Compare
4195290 to
af434f9
Compare
aws/src/main/java/org/apache/iceberg/aws/s3/AnalyticsAcceleratorInputStreamWrapper.java
Show resolved
Hide resolved
af434f9 to
a092ab2
Compare
a092ab2 to
e59dec0
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Description
This PR fixes #13295. It addresses the feature gap in AAL stream of not tracking read metrics (
readBytes,readOperations). Please note that this PR also depends on #13347 to be able to test this feature properly with an integration test.Testing
testMetricsthat works for both existingS3InputStreamand also the Analytics Accelerator Stream.Inputvalues being populated when AAL is enabled. ( This is what the user initially mentioned as missing in the above issue ). Screenshot attached: