Skip to content

Conversation

@SanjayMarreddi
Copy link
Contributor

@SanjayMarreddi SanjayMarreddi commented Jun 18, 2025

Description
This PR fixes #13295. It addresses the feature gap in AAL stream of not tracking read metrics ( readBytes, readOperations ). Please note that this PR also depends on #13347 to be able to test this feature properly with an integration test.

Testing

  • Added a new integration test testMetrics that works for both existing S3InputStream and also the Analytics Accelerator Stream.
  • Also in one of the local spark test queries, I can see the Input values being populated when AAL is enabled. ( This is what the user initially mentioned as missing in the above issue ). Screenshot attached:
Screenshot 2025-06-23 at 15 13 29

@github-actions github-actions bot added the AWS label Jun 18, 2025
Copy link

@fuatbasik fuatbasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @SanjayMarreddi . I put some comments, mostly nitpicks.

@SanjayMarreddi SanjayMarreddi force-pushed the add_metrics_in_analytics_accelerator_stream branch from b3cfc37 to cb0c707 Compare June 19, 2025 16:41
@github-actions github-actions bot added the API label Jun 19, 2025
@SanjayMarreddi SanjayMarreddi force-pushed the add_metrics_in_analytics_accelerator_stream branch from cb0c707 to 383b38b Compare June 19, 2025 16:46
@github-actions github-actions bot removed the API label Jun 19, 2025
@SanjayMarreddi SanjayMarreddi force-pushed the add_metrics_in_analytics_accelerator_stream branch 2 times, most recently from 4195290 to af434f9 Compare June 19, 2025 18:50
@SanjayMarreddi SanjayMarreddi force-pushed the add_metrics_in_analytics_accelerator_stream branch from a092ab2 to e59dec0 Compare July 8, 2025 13:14
@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Input column missing in Spark UI when using S3 Analytics Accelerator

4 participants