-
Notifications
You must be signed in to change notification settings - Fork 149
HBASE-22997 Move to SLF4J #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
petersomogyi
commented
Sep 9, 2019
- Remove org.apache.logging.log4j dependency
- Add org.slf4j dependency
- Modify Logger initialization
- Remove unused Logger from TestHBCKMetaTableAccessor
|
I just realized that the current log configuration is in XML format, probably it needs to be migrated to a properties file. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
8175601 to
b716a58
Compare
b716a58 to
dda892d
Compare
|
Updated PR based on @busbey 's comments over Jira. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
saintstack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logs that come out look ok? If so +1.
Yes, log messages are the same as before and the |