Skip to content

Conversation

@petersomogyi
Copy link
Contributor

  • Remove org.apache.logging.log4j dependency
  • Add org.slf4j dependency
  • Modify Logger initialization
  • Remove unused Logger from TestHBCKMetaTableAccessor

@petersomogyi
Copy link
Contributor Author

I just realized that the current log configuration is in XML format, probably it needs to be migrated to a properties file.

@asf-ci
Copy link

asf-ci commented Sep 9, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/89/

@asf-ci
Copy link

asf-ci commented Sep 9, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/90/

@petersomogyi
Copy link
Contributor Author

Updated PR based on @busbey 's comments over Jira.

@asf-ci
Copy link

asf-ci commented Sep 9, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/91/

@asf-ci
Copy link

asf-ci commented Sep 9, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-HBASE-OPERATOR-TOOLS-Build/92/

Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs that come out look ok? If so +1.

@petersomogyi
Copy link
Contributor Author

Logs that come out look ok?

Yes, log messages are the same as before and the -d debug flag works as well.

@petersomogyi petersomogyi merged commit 0e96351 into apache:master Sep 10, 2019
@petersomogyi petersomogyi deleted the HBASE-22997 branch September 23, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants