HBASE-25874 [hbase-operator-tools]Add tool for identifying 'unknown s… #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervers' from master logs, then submit SCPs for each of those.
|
💔 -1 overall
This message was automatically generated. |
joshelser
requested changes
May 10, 2021
Member
joshelser
left a comment
joshelser
left a comment
There was a problem hiding this comment.
I think my main worry is about relying on log file parsing for this. That's not to say this is flawed -- it just is what it is.
Is there a reason you went for this approach rather than trying to read meta and interrogate the Master as to who the active RegionServers are?
| } | ||
| } | ||
| } | ||
| HBCK2 hbck2 = new HBCK2(conf); |
Member
There was a problem hiding this comment.
What about at dryrun option which can be run first to make sure reasonable servernames are parsed?
hbase-tools/src/main/java/org/apache/hbase/RegionsOnUnknownServersRecoverer.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Yeah, it's fragile indeed, but we are targeting this mainly for the unfortunate souls running hbase versions lower than 2.2.7, 2.3.5 and 2.4.7, as mentioned on the readme, so there shouldn't be any changes on logging format for these already released versions. For any version from the above mentioned onwards, there's already hbck2 recoverUnknown method.
Although meta is already online, master has not completed initialisation (because of namespace table region stuck on a unknown server), so it pushes back any client requests. |
Member
Argh. The gift that keeps on giving. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Contributor
petersomogyi
left a comment
petersomogyi
left a comment
There was a problem hiding this comment.
Looks fine overall. Some nits.
| } | ||
| } else { | ||
| LOG.error("Wrong number of arguments. " | ||
| + "Arguments are: <PATH_TO_MASTER_LOGS> [dryRun]"); |
Contributor
There was a problem hiding this comment.
From the usage message it is not obvious that the [dryRun] parameter should be true.
Contributor
Author
There was a problem hiding this comment.
Just wanted to mention the available options here. I guess we can explain the dryRun option in the README only?
Contributor
There was a problem hiding this comment.
Having it in the readme is enough but in my opinion, it is still not clear what an operator should use as the second parameter.
hbase org.apache.hbase.RegionsOnUnknownServersRecoverer /var/log/hbase.log true
hbase org.apache.hbase.RegionsOnUnknownServersRecoverer /var/log/hbase.log dryRun
Anything passed that is not true will schedule SCPs because the default option is dryrun=false.
hbase-tools/README.md
Outdated
| This tool requires the master logs path as parameter. Assuming classpath is properly set, can be run as follows: | ||
|
|
||
| ``` | ||
| $ hbase org.apache.hbase.RegionsOnUnknownServersRecoverer PATH_TO_MASTER_LOGS |
Contributor
There was a problem hiding this comment.
The dry-run option is not mentioned here.
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
approved these changes
May 12, 2021
|
🎊 +1 overall
This message was automatically generated. |
Member
|
Belated +1 from me. Thanks for the dryRun option, Wellington. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ervers' from master logs, then submit SCPs for each of those.