Skip to content

HBASE-25529 [hbase-operator-tools] Fix OOME "unable to create new nat… #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wchevreuil merged 5 commits into from
Jan 27, 2021
Merged

HBASE-25529 [hbase-operator-tools] Fix OOME "unable to create new nat… #80

wchevreuil merged 5 commits into from
Jan 27, 2021

Conversation

@wchevreuil
Copy link
Contributor

@wchevreuil wchevreuil commented Jan 26, 2021

…ive thread" on UTs

@Apache-HBase
Copy link

Apache-HBase commented Jan 26, 2021

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+0 🆗 asflicense 0m 0s ASF License check generated no output?
1m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #80
Optional Tests dupname asflicense shellcheck shelldocs
uname Linux 3aa407b63649 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool maven
git revision master / 9760397
Max. process+thread count 34 (vs. ulimit of 5000)
modules C: U:
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/1/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 26, 2021

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 37s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 spotbugs 0m 0s spotbugs executables are not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 0m 44s master passed
+1 💚 compile 0m 8s master passed
+1 💚 checkstyle 0m 6s master passed
+1 💚 javadoc 0m 7s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 9s the patch passed
+1 💚 compile 0m 7s the patch passed
+1 💚 javac 0m 7s the patch passed
+1 💚 checkstyle 0m 3s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 5s the patch passed
_ Other Tests _
+1 💚 unit 1m 46s hbase-tools in the patch passed.
+1 💚 asflicense 0m 5s The patch does not generate ASF License warnings.
4m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/2/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #80
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 7303532fb0f8 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool maven
git revision master / 9760397
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/2/testReport/
Max. process+thread count 1271 (vs. ulimit of 5000)
modules C: hbase-tools U: hbase-tools
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/2/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi
Copy link
Contributor

petersomogyi commented Jan 27, 2021

The change looks good. We could retrigger to have confidence the OOME disappeared.

@Apache-HBase
Copy link

Apache-HBase commented Jan 27, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 spotbugs 0m 0s spotbugs executables are not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 0m 26s master passed
+1 💚 compile 0m 16s master passed
+1 💚 checkstyle 0m 10s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 2s Maven dependency ordering for patch
+1 💚 mvninstall 0m 20s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
-1 ❌ checkstyle 0m 4s hbase-hbck2: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 10s the patch passed
_ Other Tests _
+1 💚 unit 4m 6s hbase-hbck2 in the patch passed.
+1 💚 unit 2m 5s hbase-tools in the patch passed.
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
9m 49s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/3/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #80
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 9696684c6d47 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool maven
git revision master / 9760397
Default Java Oracle Corporation-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/3/artifact/yetus-precommit-check/output/diff-checkstyle-hbase-hbck2.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/3/testReport/
Max. process+thread count 1270 (vs. ulimit of 5000)
modules C: hbase-hbck2 hbase-tools U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/3/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

petersomogyi
petersomogyi approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢
Please revert the UT changes before merging.

@Apache-HBase
Copy link

Apache-HBase commented Jan 27, 2021

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+0 🆗 spotbugs 0m 0s spotbugs executables are not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 0m 26s master passed
+1 💚 compile 0m 17s master passed
+1 💚 checkstyle 0m 9s master passed
+1 💚 javadoc 0m 11s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 3s Maven dependency ordering for patch
+1 💚 mvninstall 0m 19s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
+1 💚 checkstyle 0m 7s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 10s the patch passed
_ Other Tests _
+1 💚 unit 3m 46s hbase-hbck2 in the patch passed.
+1 💚 unit 1m 44s hbase-tools in the patch passed.
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
8m 55s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/4/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #80
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 9485d307e049 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool maven
git revision master / 9760397
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/4/testReport/
Max. process+thread count 1276 (vs. ulimit of 5000)
modules C: hbase-hbck2 hbase-tools U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-80/4/console
versions git=2.20.1 shellcheck=0.5.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil wchevreuil merged commit 2958eeb into apache:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersomogyi petersomogyi petersomogyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wchevreuil @Apache-HBase @petersomogyi